[Due for payment 2025-09-19] [$250] Expense - Unable to sort expenses after split

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-439/folder/13176791/41237172/861418493
Email or phone of affected tester (no customers): sdhshssdjiosdndjs@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense in the workspace chat
4. Open the expense report
5. Click More > Split
6. On split page, edit the amount of one of the splits to be lower than the original amount
7. Click Save
8. Click Total on the table header to sort the expenses

Expected Result:

The expenses can be sorted after split

Actual Result:

The expenses cannot be sorted after split

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6927502_1756232494799.Screen_Recording_2025-08-27_at_02.17.48.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021960478703209653842
• Upwork Job ID: 1960478703209653842
• Last Price Increase: 2025-08-26

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Unable to sort expenses after split

What is the root cause of that problem?

For split transactions the modifiedAmount is the real split amount value but we are sorting it with amount key here

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 85 to 89 in f54a2c1

	const getTransactionKey = (transaction: OnyxTypes.Transaction, key: SortableColumnName) => {
	const dateKey = transaction.modifiedCreated ? 'modifiedCreated' : 'created';
	return key === CONST.SEARCH.TABLE_COLUMNS.DATE ? dateKey : key;
	};

What changes do you think we should make in order to solve the problem?

We should use the key modifiedAmount if it exists here

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 85 to 89 in f54a2c1

	const getTransactionKey = (transaction: OnyxTypes.Transaction, key: SortableColumnName) => {
	const dateKey = transaction.modifiedCreated ? 'modifiedCreated' : 'created';
	return key === CONST.SEARCH.TABLE_COLUMNS.DATE ? dateKey : key;
	};

if (key === CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT) {
        return typeof transaction.modifiedAmount === 'number' ? 'modifiedAmount' : 'amount';
    }

We can use a better switch to consider other modified fields too like modifiedCurrency and others too.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021960478703209653842

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[Christinadobrzyn]

I can reproduce this so sending to External

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-27 01:50:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Unable to sort expenses after split

What is the root cause of that problem?

Root cause is because for split transactions, the modifiedAmount is the real split amount value, but the sorting is using the amount key instead of considering modifiedAmount

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 85 to 88 in a083eb6

	const getTransactionKey = (transaction: OnyxTypes.Transaction, key: SortableColumnName) => {
	const dateKey = transaction.modifiedCreated ? 'modifiedCreated' : 'created';
	return key === CONST.SEARCH.TABLE_COLUMNS.DATE ? dateKey : key;
	};

What changes do you think we should make in order to solve the problem?

Replace original function by getTransactionSortValue function to use the existing getAmount utility which properly handles modifiedAmount vs amount logic

const getTransactionSortValue = (transaction: OnyxTypes.Transaction, key: SortableColumnName, report: OnyxTypes.Report) => {
    switch (key) {
        case CONST.SEARCH.TABLE_COLUMNS.DATE:
            return transaction.modifiedCreated ?? transaction.created;
        case CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT:
            // Use getAmount utility which properly handles modifiedAmount vs amount logic
            // This ensures split transactions are sorted by their actual split amount
            return getAmount(transaction, isExpenseReport(report));
        // Optional: We can consider this or just handle Date and Total Amount like the original one
        case CONST.SEARCH.TABLE_COLUMNS.MERCHANT:
            return transaction.modifiedMerchant ?? transaction.merchant;
        default:
            return transaction[key as keyof OnyxTypes.Transaction];
    }
};

Then update this place to call new function

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 156 in a083eb6

.sort((a, b) => compareValues(a[getTransactionKey(a, sortBy)], b[getTransactionKey(b, sortBy)], sortOrder, sortBy, localeCompare))

We should also add useAbsoluteValues = false this props to compareValues to disable the compare absolute value if for the negative sorting case

function compareValues(a: unknown, b: unknown, sortOrder: SortOrder, sortBy: string, localeCompare: LocaleContextProps['localeCompare'], useAbsoluteValues = false): number {

...

    if (typeof a === 'number' && typeof b === 'number') {
        const aValue = useAbsoluteValues ? Math.abs(a) : a;
        const bValue = useAbsoluteValues ? Math.abs(b) : b;
        return isAsc ? aValue - bValue : bValue - aValue;
    }

App/src/libs/SearchUIUtils.ts

Line 1594 in c5d59f4

function compareValues(a: unknown, b: unknown, sortOrder: SortOrder, sortBy: string, localeCompare: LocaleContextProps['localeCompare']): number {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add test to test the MoneyRequestReportTransactionList - Transaction Sorting

What alternative solutions did you explore? (Optional)

We should update the getTransactionKey function to handle the amount field properly by returning the appropriate amount value (considering modifiedAmount vs amount) rather than just the field name

    if (key === CONST.SEARCH.TABLE_COLUMNS.DATE) {
        return dateKey;
    }
    if (key === CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT) {
        // For amount sorting, use modifiedAmount if available, otherwise use amount
        // This ensures split transactions are sorted by their actual split amount
        return transaction.modifiedAmount !== undefined ? 'modifiedAmount' : 'amount';
    }
    return key;

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 87 in a083eb6

return key === CONST.SEARCH.TABLE_COLUMNS.DATE ? dateKey : key;

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-27 02:12:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expenses cannot be sorted after split

What is the root cause of that problem?

All split transactions have the amount as the amount from the original transaction. The real amount is in modifiedAmount field

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 156 in 0061124

.sort((a, b) => compareValues(a[getTransactionKey(a, sortBy)], b[getTransactionKey(b, sortBy)], sortOrder, sortBy, localeCompare))

Because we get the value to compare from the amount field, nothing happen

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 85 to 87 in 0061124

	const getTransactionKey = (transaction: OnyxTypes.Transaction, key: SortableColumnName) => {
	const dateKey = transaction.modifiedCreated ? 'modifiedCreated' : 'created';
	return key === CONST.SEARCH.TABLE_COLUMNS.DATE ? dateKey : key;

What changes do you think we should make in order to solve the problem?

Instead of returning the key, we can create a function to get the comparison value and use the existing util to get the correct value from the transaction.

We have an important note for the amount field. The amount from the expense report is negative, so we should use getAmount function to return the positive amount. We also have a problem if the transaction has a different currency from the workspace currency. To resolve this issue, the backend should return the correct originalAmount in the transaction data, allowing us to compare it with others (currently, the backend returns the originalAmount as 0).

const getSortValue = (transaction: OnyxTypes.Transaction, key: SortableColumnName, report: OnyxTypes.Report) => {
    switch(key) {
        case CONST.SEARCH.TABLE_COLUMNS.DATE:
            return getCreated(transaction);
        case CONST.SEARCH.TABLE_COLUMNS.MERCHANT:
            return getMerchant(transaction);
        case CONST.SEARCH.TABLE_COLUMNS.CATEGORY:
            return getCategory(transaction);
        case CONST.SEARCH.TABLE_COLUMNS.TAG:
            return getTag(transaction);
        case CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT:
            return getAmount(transaction, isExpenseReport(report), transaction.reportID === CONST.REPORT.UNREPORTED_REPORT_ID);
        default:
            return '';
    }
}

.sort((a, b) => compareValues(getSortValue(a, sortBy, report), getSortValue(b, sortBy, report), sortOrder, sortBy, localeCompare))

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 156 in 0061124

.sort((a, b) => compareValues(a[getTransactionKey(a, sortBy)], b[getTransactionKey(b, sortBy)], sortOrder, sortBy, localeCompare))

The compareValues function always compares the positive amount; we should update and remove the convert to abs logic here or we should define a new param to control compare original amount or compare the positive value and pass this parameter accordingly when we want to compare the original value.

App/src/libs/SearchUIUtils.ts

Lines 1585 to 1600 in ae5f666

	function compareValues(a: unknown, b: unknown, sortOrder: SortOrder, sortBy: string, localeCompare: LocaleContextProps['localeCompare']): number {
	const isAsc = sortOrder === CONST.SEARCH.SORT_ORDER.ASC;
	if (a === undefined || b === undefined) {
	return 0;
	}
	if (typeof a === 'string' && typeof b === 'string') {
	return isAsc ? localeCompare(a, b) : localeCompare(b, a);
	}
	if (typeof a === 'number' && typeof b === 'number') {
	const aValue = sortBy === CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT ? Math.abs(a) : a;
	const bValue = sortBy === CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT ? Math.abs(b) : b;
	return isAsc ? aValue - bValue : bValue - aValue;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.