Skip to content

[$250] [Due for payment 2025-09-22] [HOLD] [Change Approver] Prevent reports from being assigned to the submitter for approval #69273

@garrettmknight

Description

@garrettmknight

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: N/A
Slack conversation (hyperlinked to channel name): N/A

Action Performed for "Bypass approver":

  1. Enable "Prevent self-approvals" on the workspace
  2. Submitter A (also Admin) submits a report to Approver A via the workflow
  3. Submitter A (also Admin) selects "Change Approver" from the report "More" menu > "Bypass approver"

Expected Result:

A list of eligible approvers will include all members of the workspace except Approver A and the submitter, since they cannot approve.

Actual Result:

A list of eligible approvers will include all members of the workspace except Approver A. This means that the admin can effectively assign their own report for approval.

Action Performed for "Add approver":

  1. Enable "Prevent self-approvals" on the workspace
  2. Submitter A (also Admin) submits a report to Approver A via the workflow
  3. Submitter A (also Admin) selects "Change Approver" from the report "More" menu > "Add approver"

Expected Result:

A list of eligible approvers will include all members of the workspace except Approver A and the submitter, since they cannot approve.

Actual Result:

A list of eligible approvers will include all members of the workspace except Approver A. This means that the admin can effectively assign their own report for approval.

Workaround:

The submitter will need to change the approver again to unblock approval.

Platforms:

ALL

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021970189234050060977
  • Upwork Job ID: 1970189234050060977
  • Last Price Increase: 2025-09-22
  • Automatic offers:
    • truph01 | Contributor | 108866184

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type
No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions