Cleanup: `receiptFilename` is inconsistently being sent to the frontend

[tgolen]

Coming from Slack

Problem

When this PR added a frontend migration to rename receiptFilename to filename, it only corrected one place in the backend PR. There are multiple places in the backend where receiptFilename is being sent to the frontend, so the frontend migration is still happening and it wastes app startup time.

Solution

Find the other places in the backend that are returning receiptFilename and have them return filename instead.

Remove the frontend migration.

cc @shubham1206agra

[tgolen]

Daily Update

• I asked about this in Slack to get some more opinions on how to best clean this up

Next Steps

• @tgolen get some consensus in that thread and then implement it

ETA

• Friday, Sep 5

[tgolen]

Conclusion

We decided that the RenameReceiptFilename migration was the wrong thing to do in the first place and a mistake. Rather than leaving the frontend to reference filename, we should have changed the frontend to reference receiptFilename. With that, we agreed to solve it like this:

• BE - Update the CreateDistanceRequest API command to return both filename and receiptFilename (right now it only returns filename)
• FE - Refactor the RenameReceiptFilename migration to rename transaction.filename to transaction.receiptFilename (the opposite of what it is doing today)
• FE - Refactor all the code in the app to reference transaction.receiptFilename instead (it might take multiple PRs)
• BE - No longer return filename from CreateDistanceRequest
• FE - Remove the RenameReceiptFilename Onyx migration after 1 month of not being run in the logs

With that, I'll create FE issues for each of those. @shubham1206agra Would you want to work on those, or at least be the C+ assigned to them?

[shubham1206agra]

@tgolen Assign me and @ikevin127 here

[tgolen]

I'll get these issues created today and assign both of you! I'll also start on the backend work