[Due for payment 2025-09-16] [$250] Reports - After moving expense as approver, RHP shows not here page while it is closing

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.97-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-349/folder/13176670/41237099/849025472
Email or phone of affected tester (no customers): sdjoisnjosodi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• User A invites User B to the workspace.
• User A makes User B the workspace approver.
• User B does not have any expense report in his account.

1. Go to staging.new.expensify.com
2. [User A] Create an expense in the workspace chat and click Submit on the expense preview.
3. [User A] Repeat Step 2 to create another report.
4. [User B] Open workspace chat with User A.
5. [User B] Go to Reports > Reports.
6. [User B] Select one of the expenses via checkbox.
7. [User B] Click green dropdown button > Move expense.
8. [User B] Select another report.

Expected Result:

After moving expense as approver, RHP will not show not here page while it is closing.

Actual Result:

After moving expense as approver, RHP shows not here page while it is closing.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021960638575265447414
• Upwork Job ID: 1960638575265447414
• Last Price Increase: 2025-08-27

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - After moving expense as approver, RHP shows not here page while it is closing

What is the root cause of that problem?

We get not found page here:

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Lines 137 to 152 in 4cdf916

	const shouldShowNotFoundPage = useMemo(() => {
	if (expenseReports.length === 0 || shouldShowNotFoundPageFromProps) {
	return true;
	}
	const transactionReport = transactionsReports.at(0);
	if (!transactionReport) {
	return false;
	}
	const isAdmin = isPolicyAdmin(reportPolicy);
	const isOpen = isOpenReport(transactionReport);
	const isSubmitter = isReportOwner(transactionReport);
	// If the report is Open, then only submitters, admins can move expenses
	return isOpen && !isAdmin && !isSubmitter;
	}, [transactionsReports, reportPolicy, expenseReports.length, shouldShowNotFoundPageFromProps]);

So this is true, when we are moving to another report, but as screen has transition effect we get this page

This happens because we get transactionsReports from selectedTransactions:

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Line 18 in 4cdf916

const {selectedTransactions, clearSelectedTransactions} = useSearchContext();

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Lines 24 to 33 in 4cdf916

	const transactionsReports = useMemo(() => {
	const reports = Object.values(selectedTransactions).reduce((acc, transaction) => {
	const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction.reportID}`];
	if (report) {
	acc.add(report);
	}
	return acc;
	}, new Set<Report>());
	return [...reports];
	}, [allReports, selectedTransactions]);

And then we clear these elements when selecting an item immediately:

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Lines 35 to 45 in 4cdf916

	const selectReport = (item: TransactionGroupListItem) => {
	if (selectedTransactionsKeys.length === 0) {
	return;
	}
	const reportNextStep = allReportNextSteps?.[`${ONYXKEYS.COLLECTION.NEXT_STEP}${item.value}`];
	changeTransactionsReport(selectedTransactionsKeys, item.value, allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`], reportNextStep);
	clearSelectedTransactions();
	Navigation.goBack();
	};

And in this case, when the page closes, we end up in the first if:

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Lines 138 to 140 in 4cdf916

	if (expenseReports.length === 0 || shouldShowNotFoundPageFromProps) {
	return true;
	}

What changes do you think we should make in order to solve the problem?

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Lines 35 to 45 in 4cdf916

	const selectReport = (item: TransactionGroupListItem) => {
	if (selectedTransactionsKeys.length === 0) {
	return;
	}
	const reportNextStep = allReportNextSteps?.[`${ONYXKEYS.COLLECTION.NEXT_STEP}${item.value}`];
	changeTransactionsReport(selectedTransactionsKeys, item.value, allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${item.policyID}`], reportNextStep);
	clearSelectedTransactions();
	Navigation.goBack();
	};

We need to clear selected items after animation ends

We should follow our patern to do such things with InteractionManager:

InteractionManager.runAfterInteractions(() => {
clearSelectedTransactions();
        });

We need to find other places where this component is used and apply these changes.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We can add debounce to this function
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021960638575265447414

[JmillsExpensify]

Opening up to the community