[Due for payment 2025-11-19] [$250] Add more report fields for optimistic report names

[neil-marcellini]

Problem

As described in the parent issue, we currently do not support optimistic report name computation for several formula parts referencing basic report fields. These parts are listed below.

{report:id} – Base62 report ID
{report:status} – Report status
{report:expensescount} – Number of expenses in report

Solution

Please add support for these report formula parts in the optimistic computation within App.

Here is the current back-end C++ implementation, which you will likely find useful for proposals.

report:id

    if (partName == "id") {
        return Report::formatIDAsBase62(reportID);
    }
string Report::formatIDAsBase62(int64_t id)
{
    string base62 = Num::asBase62String(id);
    string padding(11 - base62.size(), '0');
    return 'R' + padding + base62;
}

string Num::asBase62String(int64_t from)
{
    if (from < 0) {
        throw out_of_range("Negative values not supported");
    }

    string result = "00000000000";
    size_t ptr = 10;
    while (from) {
        result[ptr--] = base62alphabet[from % 62];
        from /= 62;
    }

    for (ptr = 0; ptr < 10; ptr++) {
        if (result[ptr] != '0') {
            break;
        }
    }

    return result.substr(ptr);
}

const char* Num::base62alphabet = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";

report:status

    if (partName == "status") {
        const Report::statuses status = static_cast<Report::statuses>(reportJSON.getIntMemberWithDefault("status"));
        return Report::STATUSES[status];
    }

const char* Report::STATUSES[Report::STATUS_NUM_STATUSES] = {
    "Open",
    "Processing",
    "Archived",
    "Approved",
    "Reimbursed",
};

report:expensescount

I have created an internal issue to start returning this field to NewDot. We will return the transactions count field to Onyx and then App needs to optimistically update this field whenever a transaction is added, deleted, or moved away from a report.

• https://github.com/Expensify/Expensify/issues/546858

    if (partName == "expensescount") {
        return to_string(reportJSON.getIntMemberWithDefault("transactionCount"));
    }

---

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021957525358844302093
• Upwork Job ID: 1957525358844302093
• Last Price Increase: 2025-09-11

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021957525358844302093

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add more report fields for optimistic report names

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Add new util functions (May have some minor update/optimization during PR phase)

/**
 * Format a report ID to Base62 format
 */
function formatReportID(reportID: string | undefined): string {
    if (!reportID) {
        return '';
    }

    const numericReportID = parseInt(reportID, 10);
    if (Number.isNaN(numericReportID)) {
        return '';
    }

    return getBase62ReportID(numericReportID);
}

/**
 * Format a report status number to human-readable string
 */
function formatReportStatus(statusNum: number | undefined): string {
    if (statusNum === undefined) {
        return '';
    }

    return getHumanReadableStatus(statusNum);
}

/**
 * Get the count of expenses (transactions) in a report
 */
// Can update to return number if needed
function formatExpensesCount(reportID: string | undefined): string {
    if (!reportID) {
        return '0';
    }

    const transactions = getReportTransactions(reportID);
    if (!transactions) {
        return '0';
    }

    // Filter out partial transactions (incomplete/draft transactions)
    const completeTransactions = transactions.filter((transaction) => !isPartialTransaction(transaction));
    return completeTransactions.length.toString();
}

Add new handler here

        case 'id':
            return formatReportID(report.reportID);
        case 'status':
            return formatReportStatus(report.statusNum);
        case 'expensescount':
            return formatExpensesCount(report.reportID);

App/src/libs/Formula.ts

Lines 243 to 261 in 869b6ad

	switch (field.toLowerCase()) {
	case 'type':
	return formatType(report.type);
	case 'startdate':
	return formatDate(getOldestTransactionDate(report.reportID), format);
	case 'total':
	return formatAmount(report.total, getCurrencySymbol(report.currency ?? '') ?? report.currency);
	case 'currency':
	return report.currency ?? '';
	case 'policyname':
	case 'workspacename':
	return policy?.name ?? '';
	case 'created':
	// Backend will always return at least one report action (of type created) and its date is equal to report's creation date
	// We can make it slightly more efficient in the future by ensuring report.created is always present in backend's responses
	return formatDate(getOldestReportActionDate(report.reportID), format);
	default:
	return part.definition;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add new test cases in FormulaTest.ts

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[elizhabiboullah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report titles that use formula fields are only partially supported by the offline-first optimistic name generator

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Add placeholder support in

App/src/libs/ReportUtils.ts

Line 6009 in fa220bd

function populateOptimisticReportFormula(formula: string, report: OptimisticExpenseReport, policy: OnyxEntry<Policy>): string {

• {report:id} -> Use

  App/src/libs/getBase62ReportID.ts

  Line 8 in fa220bd

  export default function getBase62ReportID(reportID: number): string {

• {report:expensescount} -> Count non-deleted report transactions via existing report → transactions helpers
• {report:reimbursable} / {report:nonreimbursable} -> Use

  App/src/libs/ReportUtils.ts

  Line 3732 in fa220bd

  function getMoneyRequestSpendBreakdown(report: OnyxInputOrEntry<Report>, searchReports?: SearchReport[]): SpendBreakdown {

  and format with convertToDisplayString(amount, report.currency)

  App/src/libs/CurrencyUtils.ts

  Line 108 in fa220bd

  function convertToDisplayString(amountInCents = 0, currency: string = CONST.CURRENCY.USD): string {

the title field source is already wired

getTitleReportField()

App/src/libs/ReportUtils.ts

Lines 3871 to 3873 in fa220bd

	function getTitleReportField(reportFields: Record<string, PolicyReportField>) {
	return Object.values(reportFields).find((field) => isReportFieldOfTypeTitle(field));
	}

and getReportFieldsByPolicyID()

App/src/libs/ReportUtils.ts

Lines 3895 to 3897 in fa220bd

	function getReportFieldsByPolicyID(policyID: string | undefined): Record<string, PolicyReportField> {
	if (!policyID) {
	return {};

are used when building optimistic expense reports and empty reports:

App/src/libs/ReportUtils.ts

Line 6171 in fa220bd

expenseReport.reportName = populateOptimisticReportFormula(titleReportField.defaultValue, expenseReport, policy);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[github-actions]

⚠️ @elizhabiboullah Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).