[Due for payment 2025-09-02] [$250] Accounting - Resizing the window on the QBD setup page should not trigger any error

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #66773
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Web, Desktop
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Sign up with a Gmail address that includes a +
3. Select Track and budget expenses. Complete the flow by skipping the remaining steps.
4. Create a workspace.
5. Go to more features > Toggle on 'Accounting' > go to Accounting.
6. Click 'Connect' button in QBD
7. Click Upgrade > Got it, thanks > Done
8. Disconnect QBD by clicking the three dots menu
9. Click 'Connect' button in QBD again
10. Reduce the window size

Expected Result:

Resizing the window on QBD setup page should not trigger any error.

Actual Result:

An error is thrown after resizing the window on QBD setup page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021955006124261114142
• Upwork Job ID: 1955006124261114142
• Last Price Increase: 2025-08-11
• Automatic offers:
• allgandalf | Reviewer | 108392676
• FitseTLT | Contributor | 108392679

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting - Resizing the window on the QBD setup page should not trigger any error

What is the root cause of that problem?

We are navigating to the POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL based on the screen size here for small screen size

App/src/components/ConnectToQuickbooksDesktopFlow/index.tsx

Lines 11 to 14 in b743652

	useEffect(() => {
	if (isSmallScreenWidth) {
	Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL.getRoute(policyID));
	} else {

App/src/pages/workspace/accounting/utils.tsx

Lines 71 to 72 in b743652

	if (isSmallScreenWidth) {
	return ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_SETUP_REQUIRED_DEVICE_MODAL.getRoute(policyID);

What changes do you think we should make in order to solve the problem?

BTW it was implemented here to address mobile platform so it should only navigate for mobile by using isMobile check

We can do the same here but for this as the code also applies for native platforms we will also need to add an isNative (getPlatform() ,IOS, ANDROID) check.
In place of isMObile check we can use MOBILE_WEB check on getPlatform passing shouldMobileWebBeDistinctFromWeb

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021955006124261114142

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[allgandalf]

Proposal from @FitseTLT LGTM!

🎀 👀 🎀 C+ reviewed