[Due for payment 2025-09-26] [$250] Reports - Feed filter still shows card feed after workspace with card feed is deleted

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.90-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #67799
Email or phone of affected tester (no customers): sdnjodsijsoijois@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• Create two workspaces - Workspace A and B.
• Add Chase bank account in Workspace A Company Cards settings.
• Add Wells Fargo bank account in Workspace B Company Cards settings.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Go to Unapproved card.
4. Click Feed filter.
   → Two feeds are present in the filter dropdown - Chase and Wells Fargo.
5. Delete one of the workspaces.
6. Go to Reports.
7. Go to Unapproved card.
8. Click Feed filter.

Expected Result:

Feed filter will disappear because there is only one available card feed after deleting one of the workspaces.

Actual Result:

Feed filter does not disappear and it shows both card feeds when there is only one available card feed after deleting one of the workspaces.
It only disappears after reset app.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021953906361516917881
• Upwork Job ID: 1953906361516917881
• Last Price Increase: 2025-08-08

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Feed is still shown in filter list after the WS is deleted.

What is the root cause of that problem?

We get the feed list here.

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 84 in daeff95

const [allFeeds] = useOnyx(ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER, {canBeMissing: true});

The problem is, when we delete the WS, we don't optimistically remove all the feeds from that WS and also the BE response doesn't delete it either. It's only updated if we Clear cache & restart.

What changes do you think we should make in order to solve the problem?

We can optimistically delete the feeds from the workspace that we delete.

const workspaceAccountID = policy?.workspaceAccountID;

// add this to optimistic data if workspaceAccountID is truthy
{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${workspaceAccountID}`,
    value: null,
},

(and revert on fail)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test deleteWorkspace and assert that the feeds from that workspace is deleted.

[joekaufmanexpensify]

Interesting. Yeah, I agree if you delete the workspace/remove the feed and it has no expenses imported, we'd remove the feed from the feed filter. But if any transactions from the feed were submitted when it was removed, then I expect we'd retain it so you can still filter on the past expenses going forward. Thoughts @luacmartins @JS00001 @JmillsExpensify ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021953906361516917881

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-09 19:30:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Feed filter still shows card feed after workspace with card feed is deleted

What is the root cause of that problem?

we get the feedOptions here

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 108 in dd11c95

const options = getFeedOptions(allFeeds, allCards);

but did not check if the policy of some feed has been deleted so we can skip that feedOption

App/src/libs/SearchUIUtils.ts

Lines 1767 to 1772 in dd11c95

	function getFeedOptions(allCardFeeds: OnyxCollection<OnyxTypes.CardFeeds>, allCards: OnyxTypes.CardList) {
	return Object.values(getCardFeedsForDisplay(allCardFeeds, allCards)).map<SingleSelectItem<string>>((cardFeed) => ({
	text: cardFeed.name,
	value: cardFeed.id,
	}));
	}

What changes do you think we should make in order to solve the problem?

we should use getCardFeedsForDisplayPerPolicy to get the feeds perPolicy and pass the allPolicies to getFeedOptions so we can skip the feed of deleted policies

function getFeedOptions(allCardFeeds: OnyxCollection<OnyxTypes.CardFeeds>, allPolicies: OnyxCollection<OnyxTypes.Policy>) {
    const cardFeedsByPolicy = getCardFeedsForDisplayPerPolicy(allCardFeeds);
    const feedOptions: Record<string, CardFeedForDisplay> = {};

    Object.entries(cardFeedsByPolicy).forEach(([policyID, feeds]) => {
        const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
        if (!policy) {
            return;
        }

        feeds.forEach((feed) => {
            feedOptions[feed.id] = feed;
        });
    });
    return Object.values(feedOptions).map<SingleSelectItem<string>>((cardFeed) => ({
        text: cardFeed.name,
        value: cardFeed.id,
    }));
}

here

App/src/libs/SearchUIUtils.ts

Lines 1767 to 1772 in dd11c95

	function getFeedOptions(allCardFeeds: OnyxCollection<OnyxTypes.CardFeeds>, allCards: OnyxTypes.CardList) {
	return Object.values(getCardFeedsForDisplay(allCardFeeds, allCards)).map<SingleSelectItem<string>>((cardFeed) => ({
	text: cardFeed.name,
	value: cardFeed.id,
	}));
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we should add unit test for getFeedOptions to verify we did not get the feedOptions of deleted or pending delete policy

What alternative solutions did you explore? (Optional)

We can also use isPendingDeletePolicy to return early

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.