[$250] Distance rate - Distance rate unit on confirm page when submit track distance does not match actual settings

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.89-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-79/folder/13176877/41237355/822776701?sort=%2Bidentifier
Email or phone of affected tester (no customers): njojisoidjsosi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has a self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a distance expense.
4. Open transaction thread.
5. Remember the distance rate unit used in the track distance expense.
6. Create a workspace
7. Go to workspace settings > More features.
8. Enable Distance rates.
9. Go to Distance rates.
10. Click Settings.
11. Make sure the distance rate unit is different from the distance rate unit in the track distance expense. If the rate is the same, change Kilometers to Miles or change Miles to Kilometers. For example. rate unit in track expense is Kilometers, so change the workspace distance rate unit to Miles.
12. Go back to self DM.
13. Click Submit it to someone.
14. Select the workspace.
15. On confirm page, note that the distance rate is 0.7 / kilometer, when the workspace distance rate unit is actually Miles.
16. Click Create expense.
17. Go to transaction thread.
18. Note that the distance rate unit is 0.7 / mile which matches the workspace distance rate unit.

Expected Result:

In Step 15, the workspace distance rate on confirm page should match the distance rate settings. It should display 0.7 / mile because workspace distance rate unit is Miles.

Actual Result:

In Step 15, the workspace distance rate on confirm page does not match the distance rate settings. It displays 0.7 / kilometer when workspace distance rate unit is Miles.

In Step 18, after submitting the track expense to the workspace, the distance rate unit changes to 0.7 / mile which matches the workspace distance rate unit.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021952760509565149561
• Upwork Job ID: 1952760509565149561
• Last Price Increase: 2025-08-26
• Automatic offers:
• FitseTLT | Contributor | 108880839

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-19 00:37:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate - Distance rate unit on confirm page when submit track distance does not match actual settings

What is the root cause of that problem?

When displaying the distance rate on the confirmation page, getRate function uses useTransactionDistanceUnit = true by default, which causes getDistanceUnit to prioritize the transaction's stored distanceUnit (from the original track expense) over the workspace distance unit

App/src/components/MoneyRequestConfirmationList.tsx

Line 298 in 5c79384

const mileageRate = DistanceRequestUtils.getRate({transaction, policy, policyDraft});

This happens because in getDistanceUnit, when a transaction is provided, it returns transaction?.comment?.customUnit?.distanceUnit first, which contains the unit from the original track expense, not the workspace unit

What changes do you think we should make in order to solve the problem?

We should modify the getRate call to use useTransactionDistanceUnit: false when moving a transaction from track expense to workspace here

    const mileageRate = DistanceRequestUtils.getRate({transaction, policy, policyDraft, useTransactionDistanceUnit: false});

Or

    const mileageRate = DistanceRequestUtils.getRate({transaction, policy, policyDraft, useTransactionDistanceUnit: !isMovingTransactionFromTrackExpense});

Additionally, we need to fix the issue on the Rate Selection Page where the rate selector is also showing the transaction unit instead of the workspace unit. We should pass undefined for the transaction parameter in getDistanceUnit if isMovingTransactionFromTrackExpense is true

        const unit = transaction?.comment?.customUnit?.customUnitRateID === rate.customUnitRateID ? DistanceRequestUtils.getDistanceUnit(isMovingTransactionFromTrackExpense ? undefined : transaction, rate) : rate.unit;

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Line 66 in d0dd99f

const unit = transaction?.comment?.customUnit?.customUnitRateID === rate.customUnitRateID ? DistanceRequestUtils.getDistanceUnit(transaction, rate) : rate.unit;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate - Distance rate unit on confirm page when submit track distance does not match actual settings

What is the root cause of that problem?

When a distance expense is moved from a track expense (self DM) to a workspace, the getDistanceUnit function prioritizes the transaction's existing distance unit over the workspace's distance unit.

This causes the confirmation page to show the wrong unit.

What changes do you think we should make in order to solve the problem?

Update getDistanceUnit to

function getDistanceUnit(transaction: OnyxEntry<Transaction>, mileageRate: OnyxEntry<MileageRate>, isMovingFromTrackExpense?: boolean): Unit {
    // When moving a distance expense from track expense (self DM) to a workspace,
    // prioritize the workspace's distance unit over the transaction's existing unit
    if (isMovingFromTrackExpense && mileageRate?.unit) {
        return mileageRate.unit;
    }
    return transaction?.comment?.customUnit?.distanceUnit ?? mileageRate?.unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES;
}

Update getRate to approve one more param isMovingFromTrackExpense?: boolean, then pass to getDistanceUnit inside the function

Update current get rate logic to

    const isMovingTransactionFromTrackExpense = isMovingTransactionFromTrackExpenseUtil(action);
    const mileageRate = DistanceRequestUtils.getRate({transaction, policy, policyDraft, isMovingFromTrackExpense: isMovingTransactionFromTrackExpense});

Note: isMovingFromTrackExpense can be false this case and can be updated to a more general name

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-05 22:05:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate - Distance rate unit on confirm page when submit track distance does not match actual settings

What is the root cause of that problem?

When we move distance expense to a policy there is a useEffect that sets the default rate of the policy if the current rate is not available in the policy

App/src/components/MoneyRequestConfirmationList.tsx

Lines 434 to 438 in 8c9a198

	if (isCustomUnitRateIDForP2P && DistanceRequestUtils.getDefaultMileageRate(policy)) {
	const defaultMileageRatePolicy = DistanceRequestUtils.getDefaultMileageRate(policy);
	setCustomUnitRateID(transactionID, defaultMileageRatePolicy?.customUnitRateID);
	return;
	}

but we are only setting CustomUnitRateID so a wrong data from previous distance unit exists in transaction customUnit and we priortize the unit from transaction if it exists.

What changes do you think we should make in order to solve the problem?

We should not only set the CustomUnitRateID as there will be wrong data in the transaction.customUnit as the distanceUnit instead we should set the rate viasetMoneyRequestDistanceRate just like what happens when we select a distance rate here

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Line 98 in 8c9a198

setMoneyRequestDistanceRate(transactionID, customUnitRateID, policy, shouldUseTransactionDraft(action));

  const defaultMileageRatePolicy = DistanceRequestUtils.getDefaultMileageRate(policy);

        if (isCustomUnitRateIDForP2P && defaultMileageRatePolicy?.customUnitRateID) {
            setMoneyRequestDistanceRate(transactionID, defaultMileageRatePolicy.customUnitRateID, policy, true);

            return;
        }

We can do the same here

App/src/components/MoneyRequestConfirmationList.tsx

Line 430 in 8c9a198

setCustomUnitRateID(transactionID, matchingRate.customUnitRateID);

If we don't want to save last nvp in this case we can make it optional via param

App/src/libs/actions/IOU.ts

Lines 1267 to 1269 in 8c9a198

	if (policy) {
	Onyx.merge(ONYXKEYS.NVP_LAST_SELECTED_DISTANCE_RATES, {[policy.id]: customUnitRateID});
	}

we can also update customUnitID too if needed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate unit on confirm page when submit track distance does not match actual settings

What is the root cause of that problem?

By default we use the distance unit from the transaction instead of from the targeted workspace

App/src/libs/DistanceRequestUtils.ts

Line 365 in d0dd99f

useTransactionDistanceUnit = true,

App/src/libs/DistanceRequestUtils.ts

Line 382 in d0dd99f

const unit = getDistanceUnit(useTransactionDistanceUnit ? transaction : undefined, mileageRate);

What changes do you think we should make in order to solve the problem?

Pass useTransactionDistanceUnit to false if isMovingTransactionFromTrackExpense is true here

And then we also need to fix the issue on the Rate Selection Page

pass undefined for the transaction on getDistanceUnit if isMovingTransactionFromTrackExpense is true here

const unit = transaction?.comment?.customUnit?.customUnitRateID === rate.customUnitRateID ? DistanceRequestUtils.getDistanceUnit(isMovingTransactionFromTrackExpense ? undefined : transaction, rate) : rate.unit;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021952760509565149561

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

@alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!