[HOLD for payment 2022-01-25] Feature Request - Modify Keyboard Shortcuts modal's hotkey - Reported by: @mananjadhav

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to app
2. Login
3. initiate Keyboard shortcut Modal with 'command+?' on Mac or 'ctrl+?' on windows or Linux

Expected Result:

We should change the Keyboard Shortcuts modal's hotkey to Cmd + i or F1.

Actual Result:

With Cmd + ? it is confusing if we mean Cmd + ? or Cmd + /. We're saying it is Cmd + ? but it is actually Cmd + / and Cmd + ? ==> Cmd + Shift + ?

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photo Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639462509229700

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mananjadhav]

While this is a small fix, if made external I'd like to solve it.

Proposed Solution:

1. We need to update the CONST.KEYBOARD_SHORTCUTS.SHORTCUT_MODAL.shortcutKey from ? to 'I'.

        SHORTCUT_MODAL: {
            descriptionKey: 'openShortcutDialog',
            shortcutKey: 'I', // This line here
            modifiers: ['CTRL'],
        },

2. We also need to remove ? keycode handling lines from KeyboardShortcut/index.js, getKeyCode function.

// Remove these two lines.
case '?':
            return 191;

[roryabraham]

To whomever implements this change, please take note of the additional changes to the Keyboard Shortcuts modal being applied in this PR.

[mananjadhav]

@roryabraham I've added a proposal will wait for it to go external. I can see that we've also added a desktop menu shortcut in the PR you've linked. I can confirm that CommandOrControl+I will show up in the menu.

[roryabraham]

Cool, I know this can be worked on externally so I'm going to move it forward.