[Due for payment 2025-10-23] [$250] LHN - Empty report is not shown in LHN when workflows are disabled

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.87-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #67193
Email or phone of affected tester (no customers): dsonisdjoisjdosj1@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace settings > More features.
4. Disable Workflows.
5. Go to workspace chat.
6. Click + > Create report.
7. Open the empty report.

Expected Result:

Empty report will be shown in LHN when workflows are disabled.

Actual Result:

Empty report is not shown in LHN when workflows are disabled.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6902874_1753876003016.20250730_193603.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021959776563134771833
• Upwork Job ID: 1959776563134771833
• Last Price Increase: 2025-09-15
• Automatic offers:
• FitseTLT | Contributor | 108814236

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Empty report is not shown in LHN when workflows are disabled

What is the root cause of that problem?

In this PR, it hides reports that have total === 0, stateNum === SUBMITTED, statusNum === SUBMITTED, and only a CREATED action which matches empty reports

The optimistic report gets created with SUBMITTED state in CreateAppReport while BE return CREATED state because of this logic (This is the reason why the report show briefly)

App/src/libs/PolicyUtils.ts

Lines 529 to 531 in 2a255ab

	function isInstantSubmitEnabled(policy: OnyxInputOrEntry<Policy> | SearchPolicy): boolean {
	return policy?.autoReporting === true && policy?.autoReportingFrequency === CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT;
	}

App/src/libs/ReportUtils.ts

Lines 5974 to 5979 in 50c582d

	if (isInstantSubmitEnabledLocal) {
	return {
	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,
	};
	}

What changes do you think we should make in order to solve the problem?

Should check workflow is enabled or not as well (We may use useOnyx and then pass the values from component to avoid allPolicies will be deprecated soon

    const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`];
    const shouldHideEmptySubmittedReport = report?.total === 0 && 
        report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && 
        report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && 
        hasOnlyCreatedAction &&
        policy?.areWorkflowsEnabled;

    if (shouldHideEmptySubmittedReport) {
        return null;
    }

App/src/libs/ReportUtils.ts

Lines 8195 to 8199 in 50c582d

	// Hide empty reports that have only a `CREATED` action, a total of 0, and are in a submitted state
	// These reports should be hidden because they appear empty to users and there is nothing actionable for them to do
	if (report?.total === 0 && report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && hasOnlyCreatedAction) {
	return null;
	}

We may need to verify again to match the optimistic report with BE response

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Empty report is not shown in LHN when workflows are disabled

What is the root cause of that problem?

There was an issue here where empty submitted reports were appearing in LHN so we added a code here to remove empty submitted reports from LHN

App/src/libs/ReportUtils.ts

Lines 8201 to 8204 in d60ea77

	// These reports should be hidden because they appear empty to users and there is nothing actionable for them to do
	if (report?.total === 0 && report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && hasOnlyCreatedAction) {
	return null;
	}

but that code comes before the code that allows the current focused report

App/src/libs/ReportUtils.ts

Lines 8231 to 8233 in d60ea77

	if (report.reportID === currentReportId) {
	return CONST.REPORT_IN_LHN_REASONS.IS_FOCUSED;
	}

so LHN item will not appear for the empty report even if it is the current focused one.

What changes do you think we should make in order to solve the problem?

We still need to add it in LHN if it is the current focused report so should check that this empty submitted report is not the current focused report

if (
        currentReportId !== report.reportID &&
        report?.total === 0 &&
        report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED &&
        report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED &&
        hasOnlyCreatedAction
    ) {
        return null;
    }

Alternatively, take the code linked to empty submitted reports below the focused report code

App/src/libs/ReportUtils.ts

Lines 8231 to 8233 in d60ea77

	if (report.reportID === currentReportId) {
	return CONST.REPORT_IN_LHN_REASONS.IS_FOCUSED;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should add a test for shouldReportBeInOptionList that it doesn't hide empty submitted reports that are the current user focused.

What alternative solutions did you explore? (Optional)

[ijmalik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty report is not shown in LHN when workflows are disabled.

What is the root cause of that problem?

App/src/libs/ReportUtils.ts

Lines 8223 to 8225 in 4dc9dd5

	if (report?.total === 0 && report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && hasOnlyCreatedAction) {
	return null;
	}

This condition evaluates to true even when the report is currently focused.

What changes do you think we should make in order to solve the problem?

Replace

App/src/libs/ReportUtils.ts

Lines 8223 to 8225 in 4dc9dd5

	if (report?.total === 0 && report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && hasOnlyCreatedAction) {
	return null;
	}

With

    if (report?.total === 0 && report?.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED && hasOnlyCreatedAction && report.reportID !== currentReportId) {
        return null;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

A test case should be written/updated to verify the currently focused expense report remains visible in the LHN when all conditions are met: zero total (total=0), SUBMITTED state, only a CREATED action and workflows are disabled.

What alternative solutions did you explore? (Optional)

[RachCHopkins]

It is shown in the LHN when the Priority Mode is set to Most Recent. But not when it's set to Focus, because Focus only shows things that need action. And an empty report needs no action.

BUT when I create the empty report there is absolutely no way to add an expense to it whatsoever.

So I think the issue here is not the one in the OP. It's a totally different issue.

[FitseTLT]

It is shown in the LHN when the Priority Mode is set to Most Recent. But not when it's set to Focus, because Focus only shows things that need action. And an empty report needs no action.

BUT when I create the empty report there is absolutely no way to add an expense to it whatsoever.

So I think the issue here is not the one in the OP. It's a totally different issue.

@RachCHopkins U have misunderstood the problem. The bug is that when you open the empty report an LHN coresponding to it is not appearing which is a totally weird bug. The currently focused/open report should always have a highlighted LHN. Can you please recheck? Thx

2025-08-06.14-57-53.mp4

[RachCHopkins]

#68034 has been raised. Let's get that fixed first and then see if this is still a problem!!