[Due for payment 2025-08-29] [$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.87-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: exploratory
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Other

Action Performed:

1. Create a new gmail account
2. Choose any onboarding intent other than “Manage my team's expenses”
3. Continue the onboarding flow until you reach "Take us for a test drive" modal
4. Enter any email address not associated with an existing user
5. Click on "Start test drive"
6. On the "Confirm details" screen click on the receipt
7. Refresh page

Expected Result:

Page stays on the "Confirm details" screen or the Test Drive Receipt preview

Actual Result:

"Create expense" page is shown and "Hmm... it not here" is shown on the background

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021952717258906572021
• Upwork Job ID: 1952717258906572021
• Last Price Increase: 2025-08-05

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview

What is the root cause of that problem?

Used invalid reportID from test drive blindly (the report ID is 1 by default in onboarding step which means a creating report - so that the data is not existed --> Then causing the "Not here..." issue)

The ID is getting from here

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 29 to 30 in b17531e

	const currentURL = getCurrentUrl();
	const reportIdFromPath = currentURL && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);

Then it matches the regex check (a weak check), and go to this follow

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Line 31 in b17531e

if (reportIdFromPath) {

Since it is an invalid report --> Showing "Not here...." issue

What changes do you think we should make in order to solve the problem?

The easiest way to check if it is a valid reportID is:

First, we can get all reports that available

    const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});

Then we need to check if it is really a valid report or not, if not we need to skip it to avoid "Not here" issue
It is guarantee the correctness and prevent unexpected issues even if we update the default values for creating report later on.

 
        if (reportIdFromPath && allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportIdFromPath}`]?.reportID) {
            return reportIdFromPath;
        }

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 31 to 33 in b17531e

	if (reportIdFromPath) {
	return reportIdFromPath;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

To make sure that the check valid report ID are always up to date, we can wrap to useEffect

    const [initialReportID, setInitialReportID] = useState(() => {        
        const initialReport = ReportUtils.findLastAccessedReport(!isBetaEnabled(CONST.BETAS.DEFAULT_ROOMS), shouldOpenOnAdminRoom());
        return initialReport?.reportID ?? '';
    });

    useEffect(() => {
        const currentURL = getCurrentUrl();
        const reportIdFromPath = currentURL && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);
        
        if (reportIdFromPath && allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportIdFromPath}`]?.reportID) {
            setInitialReportID(reportIdFromPath);
        }
    }, [allReports]);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found report screen is shown after refreshing while receipt modal is shown.

What is the root cause of that problem?

This can be reproduced with another steps:

1. Open FAB > Create Expense
2. Enter any amount
3. Change the participant to a new user you never chatted before
4. Add a receipt
5. Open the receipt
6. Refresh

This happens because when we refresh while the receipt modal is open, the receipt modal page route matches the REPORT_ID_FROM_PATH regex, and the report ID from the route will be used as the report ID of the report screen.

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 28 to 33 in b73ebe2

	const [initialReportID] = useState(() => {
	const currentURL = getCurrentUrl();
	const reportIdFromPath = currentURL && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);
	if (reportIdFromPath) {
	return reportIdFromPath;
	}

If we choose a participant whom we have never chatted with before, then the report screen will be rendered with the non-existent reportID, and OpenReport will give no report found.

What changes do you think we should make in order to solve the problem?

We have a few options.

First, we can ignore the reportID if the route contains a transaction with a transaction ID of 1.

const reportIdFromPath = currentURL && !currentURL.includes('transaction\/1\/') && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);

If the transactionID is 1, then it means we are creating a new expense. This is the simplest one to check if we are creating a new expense or not.

Second, we can ignore the reportID completely for the transaction receipt page route by comparing the pathname with the transaction receipt page regex (new regex).

Third, we can create a separate route for the transaction receipt page for the new expense flow that doesn't use /r/[reportID] pattern. So, instead of

r/:reportID/transaction/:transactionID/receipt/:action?/:iouType?

we can do

:action/:iouType/receipt/:transactionID/:reportID

This will be more inline with the other IOU flow route. For example,

App/src/ROUTES.ts

Lines 629 to 630 in b73ebe2

	MONEY_REQUEST_STEP_TAX_AMOUNT: {
	route: ':action/:iouType/taxAmount/:transactionID/:reportID?',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If we choose first or second, then we can render ReportsSplitNavigator and mock getCurrentUrl to return transaction receipt page and verify the ReportScreen is rendered with reportID not from the receipt page route.

[melvin-bot]

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021952717258906572021

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)