[Due for payment 2025-08-20] [$250] Control Workspace - Error display after the Auditor submits the expense of the Employee

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.86-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2148171/test-runs/TR-211/folder/12015294/39317488/805490572
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Chat Report View

Action Performed:

Preconditions
User is an admin of a control workspace. The workspace has an Employee, and an expense has not been submitted
Admin invite and set a new user as Auditor
Admin sets the approver in the workflow as the Auditor

1. Log in to ND as the Auditor
2. Navigate the Employee Workspace chat
3. Click on an expense that has not been submitted yet
4. Click on the More button
5. Select the Submit option

Expected Result:

The Auditor can not have the Submit option in the Employee workspace chat

Actual Result:

Error display after the Auditor submits an expense of the Employee "Unexpected error. Please try again later."

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021949679617674032415
• Upwork Job ID: 1949679617674032415
• Last Price Increase: 2025-07-28
• Automatic offers:
• mkzie2 | Contributor | 108304454

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error display after the Auditor submits an expense of the Employee "Unexpected error. Please try again later."

What is the root cause of that problem?

When the auditor is set as the approver in the workflow and the draft report is created by employee, the mangerID is the employee not the auditor. It's only changed to the auditor after the employee submits the expense. The problem here is, the primary action is not submit action so !!isScheduledSubmitEnabled || primaryAction !== CONST.REPORT.SECONDARY_ACTIONS.SUBMIT; this check returns true.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 157 to 165 in db267d0

	if (isAdmin || isManager) {
	return true;
	}
	const autoReportingFrequency = getCorrectedAutoReportingFrequency(policy);
	const isScheduledSubmitEnabled = policy?.harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL;
	return !!isScheduledSubmitEnabled || primaryAction !== CONST.REPORT.SECONDARY_ACTIONS.SUBMIT;

What changes do you think we should make in order to solve the problem?

If this check isAdmin || isManager doesn't pass, we should return early false if the current user is not the submiter.

if (!isReportSubmitter) {
    return false;
}

App/src/libs/ReportSecondaryActionUtils.ts

Lines 157 to 165 in db267d0

	if (isAdmin || isManager) {
	return true;
	}
	const autoReportingFrequency = getCorrectedAutoReportingFrequency(policy);
	const isScheduledSubmitEnabled = policy?.harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL;
	return !!isScheduledSubmitEnabled || primaryAction !== CONST.REPORT.SECONDARY_ACTIONS.SUBMIT;

OPTIONAL: We can also remove isManager check since this case is never matched

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update ReportSecondaryActionUtils test to verify that the submit action isn't included if the user is not submitter/admin/manager

What alternative solutions did you explore? (Optional)

We can remove isReportApprover check here because isApproverUtils check if the user is an approver of the workspace that may not be the manager of the expense report, then this function can return early if the user is not submiter/manger/admin.

App/src/libs/ReportSecondaryActionUtils.ts

Line 138 in db267d0

if (!isReportSubmitter && !isReportApprover && !isAdmin && !isManager) {

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-29 04:14:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Control Workspace - Error display after the Auditor submits the expense of the Employee

What is the root cause of that problem?

We did not exclude auditor in canSubmitReport, ReportSecondaryActionUtils isSubmitAction, ReportPrimaryActionUtils isSubmitAction

What changes do you think we should make in order to solve the problem?

Should exclude auditor in isSubmitAction in case there is no duplication

    const isReportAuditor = isAuditor(report);
    const hasDuplicateTransactions = reportTransactions.some((transaction) => isDuplicate(transaction));
    if (isReportAuditor && !hasDuplicateTransactions) {
        return false;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add tests to ReportSecondaryActionUtils to validate that if the user is not submitter/admin/manager, the submit should not be shown

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021949679617674032415

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[alexpensify]

@mananjadhav - When you get a chance, please review if this proposal will fix the issue? Thanks!