[C+ Checklist Needs Completion] [$250] Expense created offline for new chat shows two avatar

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.82-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65921
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 /Chrome, Samsung Galaxy s10/ Chrome. Samsung Galaxy s10/ Android 12
App Component: Chat Report View

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in with any account
3. Go offline
4. Click green + button > Create expense
5. Choose any user without IOU in chat and create expense

Expected Result:

Next to the Report Preview only one avatar should display and it's the sender. and also only the sender name above Report Preview should appear.

Actual Result:

When creating an expense offline for a new chat it shows both the users avatar until returning online

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6890429_1752752855345.bandicam_2025-07-17_14-30-11-184.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021947529431034338581
• Upwork Job ID: 1947529431034338581
• Last Price Increase: 2025-07-29
• Automatic offers:
• mkzie2 | Contributor | 108237115

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[TMisiukiewicz]

I'll verify this

[TMisiukiewicz]

Checked it against my latest changes, answered here: #65921 (comment)

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense created offline for new chat shows two avatar

What is the root cause of that problem?

While creating the optimistic data for report action preview, we are not setting the childOwnerAccountID in the optimisitic data and due to this we get singleAvatarAccountID as undefined, which inturn makes reportPreviewSenderID as undefined here:

App/src/hooks/useReportAvatarDetails.ts

Lines 270 to 273 in 48a96b0

	const singleAvatarAccountID = isSendMoneyFlow ? action.childManagerAccountID : action?.childOwnerAccountID;
	const reportPreviewSenderID = areAmountsSignsTheSame && isThereOnlyOneAttendee ? singleAvatarAccountID : undefined;

which makes displayAllActors as true here as reportPreviewSenderID is undefined :

App/src/hooks/useReportAvatarDetails.ts

Line 92 in 48a96b0

const displayAllActors = isReportPreviewAction && !isTripRoom && !isPolicyExpenseChat(report) && !reportPreviewSenderID;

which leads to showing multiple avatars:

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 122 to 124 in 48a96b0

	const showMultipleUserAvatarPattern = shouldDisplayAllActors && !shouldShowSubscriptAvatar;
	const headingText = showMultipleUserAvatarPattern ? `${primaryAvatar.name} & ${secondaryAvatar.name}` : displayName;

What changes do you think we should make in order to solve the problem?

While creating the optimistic data for report preview action, we need to add the childOwnerAccountID here:

App/src/libs/ReportUtils.ts

Line 6607 in 48a96b0

reportActionID: reportActionID ?? rand64(),

        childOwnerAccountID: currentUserAccountID,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Preview:

childaccountid.mp4

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating an expense offline for a new chat it shows both the users avatar until returning online

What is the root cause of that problem?

Let's see the logic here, singleAvatarAccountID is getting from childManagerAccountID/childOwnerAccountID data of the report preview action. But the optimistic report preview action doesn't set this data here

App/src/hooks/useReportAvatarDetails.ts

Lines 270 to 273 in 48a96b0

	const singleAvatarAccountID = isSendMoneyFlow ? action.childManagerAccountID : action?.childOwnerAccountID;
	const reportPreviewSenderID = areAmountsSignsTheSame && isThereOnlyOneAttendee ? singleAvatarAccountID : undefined;

Then showMultipleUserAvatarPattern is true since singleAvatarAccountID is undefined

App/src/hooks/useReportAvatarDetails.ts

Line 92 in 48a96b0

const displayAllActors = isReportPreviewAction && !isTripRoom && !isPolicyExpenseChat(report) && !reportPreviewSenderID;

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 122 to 124 in 48a96b0

	const showMultipleUserAvatarPattern = shouldDisplayAllActors && !shouldShowSubscriptAvatar;
	const headingText = showMultipleUserAvatarPattern ? `${primaryAvatar.name} & ${secondaryAvatar.name}` : displayName;

What changes do you think we should make in order to solve the problem?

We should set childManagerAccountID and childOwnerAccountID data for the report preview action based on iouReport param. We shouldn't always set childOwnerAccountID as the current user because for the send money flow the current user is the manager, not the owner. Follow iouReport data is always correct

childOwnerAccountID: iouReport.ownerAccountID,
childManagerAccountID: iouReport.managerID,

App/src/libs/ReportUtils.ts

Line 6606 in 48a96b0

return {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update buildOptimisticReportPreview unit test to verify childOwnerAccountID, childManagerAccountID is correct

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021947529431034338581