[C+ Checklist Needs Completion] [$250] LHN - Receipt scanning remains in the LHN after the scan is finished

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.78-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1 Safari/Desktop
App Component: Left Hand Navigation (LHN)

Action Performed:

1.Navigate to https://staging.new.expensify.com
2.Navigate to the SelfDM and create expense, selecting a scan option
3.Upload a receipt that will be successful - A digital receipt will scan faster
4. Click on the receipt while scanning
5.Wait a few min for the scan to finish

Expected Result:

The new expense name is displayed in the LHN after the scan is finished

Actual Result:

Receipt scanning remains in the LHN the scan is finished

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021944777368223663701
• Upwork Job ID: 1944777368223663701
• Last Price Increase: 2025-07-21

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-23 12:13:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The LHN title still says Receipt scanning after the scan is done.

What is the root cause of that problem?

The report name depends on the transaction. If the transaction is scanning, then it returns Receipt scanning. The report name is calculated and stored in the report attributes.

App/src/libs/ReportUtils.ts

Lines 4994 to 4999 in ff9f675

	const canUseDerivedValue = report && policy === undefined && parentReportActionParam === undefined && personalDetails === undefined && invoiceReceiverPolicy === undefined;
	const attributes = reportAttributes ?? reportAttributesDerivedValue;
	const derivedNameExists = report && !!attributes?.[report.reportID]?.reportName;
	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}

In this case, after the scan completes, the report attributes aren't updated. We already have a logic to update the report attributes when the transaction is updated. We first check if there are report-related updates and then add them to the dataToIterate array. If there are no updates, then we return early.

App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts

Lines 89 to 116 in ff9f675

	if (updates.length > 0) {
	dataToIterate = prepareReportKeys(updates);
	} else if (!!transactionsUpdates || !!transactionViolationsUpdates) {
	let transactionReportIDs: string[] = [];
	if (transactionsUpdates) {
	transactionReportIDs = Object.values(transactionsUpdates).map((transaction) => `${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`);
	}
	// Also handle transaction violations updates by extracting transaction IDs and finding their reports
	if (transactionViolationsUpdates) {
	const violationTransactionIDs = Object.keys(transactionViolationsUpdates).map((key) => key.replace(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, ''));
	const violationReportIDs = violationTransactionIDs
	.map((transactionID) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]?.reportID)
	.filter(Boolean)
	.map((reportID) => `${ONYXKEYS.COLLECTION.REPORT}${reportID}`);
	// Also include chat reports for expense reports that have violations
	const chatReportIDs = violationReportIDs
	.map((reportKey) => reports?.[reportKey]?.chatReportID)
	.filter(Boolean)
	.map((chatReportID) => `${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);
	transactionReportIDs = [...transactionReportIDs, ...violationReportIDs, ...chatReportIDs];
	}
	dataToIterate = prepareReportKeys(transactionReportIDs);
	} else {
	// No updates to process, return current value to prevent unnecessary computation
	return currentValue ?? {reports: {}, locale: null};
	}

The updates array contains the report-related update of report metadata, report action, etc.

App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts

Lines 79 to 85 in ff9f675

	const updates = [
	...Object.keys(reportUpdates),
	...Object.keys(reportMetadataUpdates),
	...Object.keys(reportActionsUpdates),
	...Object.keys(reportNameValuePairsUpdates),
	...reportUpdatesRelatedToReportActions,
	];

The problem here is that, when the updates are not empty, transactionsUpdates or transactionViolationsUpdates is never processed. Because of this, the reportAttributes is not updated.

What changes do you think we should make in order to solve the problem?

If there are transactionsUpdates or transactionViolationsUpdates, then we need to append them to dataToIterate array.

if (updates.length > 0 || !!transactionsUpdates || !!transactionViolationsUpdates) {
    if (updates.length > 0) {
        dataToIterate = prepareReportKeys(updates);
    }
    if (!!transactionsUpdates || !!transactionViolationsUpdates) {
        ...
        dataToIterate.push(...prepareReportKeys(transactionReportIDs));
    }
} else {
    // No updates to process, return current value to prevent unnecessary computation
    return currentValue ?? {reports: {}, locale: null};
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test the compute function and verify that after recomputation, given report and transaction (linked to a different report) updates (sourceValues), the computed report attributes should contain both reports.

it('should contain both report attributes update when there are report and transaction updates', async () => {
    await waitForBatchedUpdates();
    // Given 2 reports and 1 transaction
    const reportID1 = '0';
    const reportID2 = '1';
    const reports: OnyxCollection<Report> = {
        [`${ONYXKEYS.COLLECTION.REPORT}${reportID1}`]: createRandomReport(Number(reportID1)),
        [`${ONYXKEYS.COLLECTION.REPORT}${reportID2}`]: createRandomReport(Number(reportID2)),
    };
    const transaction = createRandomTransaction(1);

    // When the report attributes are recomputed with both report and transaction updates
    reportAttributes.compute([reports, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined], {areAllConnectionsSet: true}).reports;
    const reportAttributesComputedValue = reportAttributes.compute([reports, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined], {sourceValues: {
        [ONYXKEYS.COLLECTION.REPORT]: {
            [`${ONYXKEYS.COLLECTION.REPORT}${reportID1}`]: reports[`${ONYXKEYS.COLLECTION.REPORT}${reportID1}`],
        },
        [ONYXKEYS.COLLECTION.TRANSACTION]: {
            [`${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`]: transaction,
        },
    }, areAllConnectionsSet: true}).reports;

    // Then the computed report attributes should contain both reports
    expect(Object.keys(reportAttributesComputedValue)).toEqual([reportID1, reportID2]);
});

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021944777368223663701

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[sobitneupane]

Thanks for the proposal, @bernhardoj

The proposal looks good to me. The code was originally introduced in this PR by @TMisiukiewicz.

@TMisiukiewicz, could you please take a look and let us know if you're okay with it?

[TMisiukiewicz]

Yeah I think it's good 👍