Android - Duplicates - Duplicates are not resolved after confirmation

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.76-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #62434
Email or phone of affected tester (no customers): applausetester+dq7@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung / Android 14
App Component: User Settings

Action Performed:

1. Log in to the app
2. Create two duplicate transactions
3. Press Review Duplicates
4. Press Keep this on any expense
5. Go through the flow and confirm the expense

Expected Result:

Only 1 expense remains with the fields that were selected in the duplicate flow

Actual Result:

Both expense remains with error

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6877577_1751588651361.2025-07-04_03.23.34.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicates are not resolved, it happens on the web too.

What is the root cause of that problem?

When we try to merge the duplicates, the transactionIDList param is empty.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Line 79 in 3bdf375

IOU.mergeDuplicates(transactionsMergeParams);

It's because the duplicates list is an empty array.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 69 to 70 in 3bdf375

	const transactionsMergeParams = useMemo(
	() => TransactionUtils.buildMergeDuplicatesParams(reviewDuplicates, duplicates ?? [], newTransaction),

duplicates is fetched from the transaction collection data, derived from reviewDuplicates?.duplicates.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 65 to 68 in 3bdf375

	const [duplicates] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}`, {
	selector: (allTransactions) => reviewDuplicates?.duplicates.map((id) => allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]),
	canBeMissing: true,
	});

reviewDuplicates?.duplicates onyx data is not available immediately, it's undefined briefly (loading), so the duplicates returns an empty array.

What changes do you think we should make in order to solve the problem?

We should add reviewDuplicates?.duplicates to the useOnyx deps so it's recalculated once it's available.

const [duplicates] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}`, {
    selector: (allTransactions) => reviewDuplicates?.duplicates.map((id) => allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]),
    canBeMissing: true,
}, [reviewDuplicates?.duplicates]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[rohit9625]

Hi @bernhardoj, since you've been contributing to Expensify, you know the code better than me. I want to ask how we load data if it hasn't been loaded already, for example in this code:

useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.reportID}`, {canBeMissing: false})

I can see the reportActions for a specific report only if I opened that report previously. Why?

[bernhardoj]

Not all data is loaded when you log in to the app. When you open the specific report, you get the report actions from the OpenReport API response.

[rohit9625]

Okay, so that means I need to call the OpenReport function to get the reportActions. I saw that OpenReport function requires multiple parameters. Is there any other function to get the just reportActions?

[bernhardoj]

I'm not aware if we have that. I think no.

[mountiny]

@FitseTLT @dominictb @luacmartins can you please take a look? QA has pointed at this issue based on this PR #62434

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[FitseTLT]

Cannot reproduce it

2025-07-08.15-47-19.mp4