[Due for payment 2025-08-13] [$250] Status - The Clear after row flickers after clicking the Save button

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.71-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1/ Desktop, Chrome, mWeb/Safari
App Component: User Settings

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Navigate to Account settings > Profile
   3.Click on Status
   4.Click on the emoji selector
3. Select an emoji
   6.Set the "Clear after" to any option
4. Click the Save button

Expected Result:

After clicking the save button, the "Clear after" row doesn't flicker

Actual Result:

The Clear after row flickers after clicking the Save button

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6868987_1750809465001.Recording__222__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021939816803115817068
• Upwork Job ID: 1939816803115817068
• Last Price Increase: 2025-07-07
• Automatic offers:
• daledah | Contributor | 107992957

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Clear after row flickers after clicking the Save button

What is the root cause of that problem?

When saving custom status, we call both updateCustomStatus and clearDraftCustomStatus at the same time

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 114 to 119 in 014edee

	updateCustomStatus({
	text: statusText,
	emojiCode: !emojiCode && statusText ? initialEmoji : emojiCode,
	clearAfter: clearAfterTime !== CONST.CUSTOM_STATUS_TYPES.NEVER ? clearAfterTime : '',
	});
	clearDraftCustomStatus();

Which leads to a race condition: for a very short amount of time draftClearAfter here

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Line 59 in 014edee

const draftClearAfter = draftStatus?.clearAfter;

and currentUserClearAfter here

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Line 56 in 014edee

const currentUserClearAfter = currentUserPersonalDetails?.status?.clearAfter ?? '';

is both empty string.

Which leads to DateUtils.getLocalizedTimePeriodDescription(dataToShow) returns never

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 67 to 68 in 014edee

	const dataToShow = draftClearAfter || currentUserClearAfter;
	return DateUtils.getLocalizedTimePeriodDescription(dataToShow);

App/src/libs/DateUtils.ts

Lines 543 to 544 in 014edee

	case '':
	return translateLocal('statusPage.timePeriods.never');

What changes do you think we should make in order to solve the problem?

We should move clearDraftCustomStatus to InteractionManager.runAfterInteractions

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 119 to 122 in 014edee

	clearDraftCustomStatus();
	navigateBackToPreviousScreenTask.current = InteractionManager.runAfterInteractions(() => {
	navigateBackToPreviousScreen();
	});

    navigateBackToPreviousScreenTask.current = InteractionManager.runAfterInteractions(() => {
        clearDraftCustomStatus();
        navigateBackToPreviousScreen();
    });

Or we can move the function clearDraftCustomStatus into navigateBackToPreviousScreen

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Or we can remove clearDraftCustomStatus function here because it was cleared when umount

App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx

Lines 146 to 155 in 014edee

	useEffect(() => {
	if (!currentUserEmojiCode && !currentUserClearAfter && !draftClearAfter) {
	updateDraftCustomStatus({clearAfter: DateUtils.getEndOfToday()});
	} else {
	updateDraftCustomStatus({clearAfter: currentUserClearAfter});
	}
	return () => clearDraftCustomStatus();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, []);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@Christinadobrzyn Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@Christinadobrzyn Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021939816803115817068

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)