[Due for payment 2025-08-05] [$250] Report-Unexpected error displayed on the "good" expense after creating vague distance expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.68-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6288571
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.5 Chrome
App Component: Money Requests

Action Performed:

1. Navigate to staging.new.expensify.com, log in with gmail account
2. Create a distance expense in the workspace chat
3. Start creating a distance expense again, disable internet connection
4. Enter vague waypoints and create an expense in the same workspace, as the first one
5. Navigate to the workspace chat and enable internet connection
6. Observe the expenses previews

Expected Result:

"Unexpected error submitting this expense. Please try again later" is displayed only on the distance expense with the vague waypoints

Actual Result:

"Unexpected error submitting this expense. Please try again later" is displayed on both distance expenses: the "good" one and the expense with the vague waypoints

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6864016_1750280487206.Recording__569.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937251646350348504
• Upwork Job ID: 1937251646350348504
• Last Price Increase: 2025-07-07
• Automatic offers:
• thelullabyy | Contributor | 107981751

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report-Unexpected error displayed on the "good" expense after creating vague distance expense

What is the root cause of that problem?

We are calculating the error based on the report and both the transactions are present in the same report that is why we get the error in both the previews.

App/src/libs/TransactionPreviewUtils.ts

Lines 202 to 204 in 3d818ef

	if (RBRMessage === undefined && hasActionWithErrors && !!reportActions) {
	const actionsWithErrors = getUniqueActionErrors(reportActions);
	RBRMessage = actionsWithErrors.length > 1 ? {translationPath: 'violations.reviewRequired'} : {text: actionsWithErrors.at(0)};

App/src/libs/TransactionPreviewUtils.ts

Line 319 in 3d818ef

const hasReportViolationsOrActionErrors = (isReportOwner(iouReport) && hasReportViolations(iouReport?.reportID)) || hasActionsWithErrors(iouReport?.reportID);

What changes do you think we should make in order to solve the problem?

While calculating the error we need to consider both the transaction and the report, so that we show error only for the particular transaction and not for the whole report.
we need to make changes here:

    if (RBRMessage === undefined && hasActionWithErrors && !!reportActions && Object.keys(transaction?.errors ?? {}).length > 0) {

and here

const hasReportViolationsOrActionErrors =
        (isReportOwner(iouReport) && hasReportViolations(iouReport?.reportID)) || (hasActionsWithErrors(iouReport?.reportID) && Object.keys(transaction?.errors ?? {}).length > 0);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

Yeah, this seems wrong.

1. An expense created might not get submitted immediately, so the error message copy itself would be more evergreen if it read: "Unexpected error creating this expense. Please try again later." Better still, if we know why this failed (i.e bad waypoints), a more pointed error message would be good.

2. The error is only with the one expense on the report, so it should only display on the preview of that expense in error.

CC: @neil-marcellini for vis.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937251646350348504