[Payment needed][$250] Expense - Message sent in expense is created as a reply in "paid elsewhere" system message

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.68-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sjdnionjsojsosidjso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open 1:1 DM.
3. Click + > Pay user.
4. Enter amount > Next.
5. Click Pay elsewhere.
6. Click on the expense preview.
7. Send a message.

Expected Result:

The message will be created in the transaction thread.

Actual Result:

The message is created as a reply in "paid elsewhere" system message.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6862845_1750184640316.20250618_022203.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021935221993053332377
• Upwork Job ID: 1935221993053332377
• Last Price Increase: 2025-06-18
• Automatic offers:
• FitseTLT | Contributor | 107795642

Issue Owner

Current Issue Owner: @hungvu193

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-17 19:08:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Message sent in expense is created as a reply in "paid elsewhere" system message

What is the root cause of that problem?

We want to add the actions to the transaction thread report in the case of one transaction thread iou/expense report here

App/src/libs/actions/Report.ts

Lines 836 to 848 in 5c2873b

	if (isMoneyRequestReport(allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`])) {
	const reportActions = allReportActions?.[reportID];
	if (reportActions) {
	const moneyRequestPreviewActions = Object.values(reportActions).filter(
	(action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isDeletedAction(action),
	);
	if (moneyRequestPreviewActions.length === 1) {
	const transactionThreadReportID = moneyRequestPreviewActions.at(0)?.childReportID;
	if (transactionThreadReportID) {
	addActions(transactionThreadReportID, text);
	return;
	}
	}

but we haven't filtered out send money actions so in send payment case it will add the action to the pay iou action

What changes do you think we should make in order to solve the problem?

We need to filter out isSentMoneyReportAction (or isPayAction) IOU actions

const moneyRequestPreviewActions = Object.values(reportActions).filter(
                (action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionsUtils.isSentMoneyReportAction(action) && !ReportActionsUtils.isDeletedAction(action),
            );

Or we can consider filtering only iou actions that have originalMessage.type as create (also split if needed).
Alternatively, we can use getSendMoneyFlowOneTransactionThreadID to identify send money flow one transaction thread.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test for addActions to assert that we don't add the action to the child thread of the isSentMoneyReportAction in the case of send payment.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021935221993053332377

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

Thanks @FitseTLT. Your proposal here looks good to me. I think we can use isSentMoneyReportAction here.

🎀 👀 🎀