[$125] Onboarding flow - "What's your name?" is shown again after skipping the selection of a workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #63199
Email or phone of affected tester (no customers): agena3@lopvede.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 14
App Component: Other

Action Performed:

Precondition:
Have a workspace in the private domain that the Employee will log in to.

Steps:

1. Go to staging.new.expensify.com
2. Sign up with a new private domain email account as Employee
3. Go through the onboarding flow, and once the "Join a workspace" page is reached, select Skip
4. Select an option from the intent selector
5. [Only Web] Note that the modal flickers

Expected Result:

After the intent selector page, the "Test drive modal" shows up.
[Only Web] The onboarding modal never flickers.

Actual Result:

After the intent selector page, the "What's your name?" page is shown again.
[Only Web] The onboarding modal flickers.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6851641_1749142892416.What_s_your_name_page_twice.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021930988234994129983
• Upwork Job ID: 1930988234994129983
• Last Price Increase: 2025-06-15
• Automatic offers:
• gijoe0295 | Contributor | 107650811

Issue Owner

Current Issue Owner: @lakchote

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021930988234994129983

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[twisterdotcom]

Thought this was just a flicker, but it's odd that we actually show the name entry twice.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"What's your name?" is shown again after skipping the selection of a workspace

What is the root cause of that problem?

In onboarding purpose step, we only end the onboarding if that private domain has accessible workspaces; and the user has provided BOTH first name AND last name:

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Lines 88 to 89 in a1e6648

	if (isPrivateDomainAndHasAccessiblePolicies && personalDetailsForm?.firstName && personalDetailsForm?.lastName) {
	completeOnboarding({

In this case, user has only provided first name so the above condition fails and it just opens the name step.

What changes do you think we should make in order to solve the problem?

User only needs to provide either first name or last name:

isPrivateDomainAndHasAccessiblePolicies && (personalDetailsForm?.firstName || personalDetailsForm?.lastName)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!