[Due for payment 2025-06-17] [$250] Expense - Submit button is not shown in More menu for workspace admin

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #62791
Email or phone of affected tester (no customers): applausetester+020631kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Delay submission is enabled, Add approval is disabled.
• User A is a workspace owner, User B is a workspace admin of the same workspace.

1. Go to staging.new.expensify.com
2. [User A] Go to workspace chat.
3. [User A] Submit an expense.
4. [User A] Click Submit on the expense preview.
5. [User A] Click on the expense preview.
6. [User A] Click More > Undo close.
7. [User B] Go to workspace chat with User A.
8. [User B] Click on the expense preview.
9. [User B] Click More.

Expected Result:

User B should be able to see Submit button in More menu.

Actual Result:

User B does not see Submit button in More menu.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6849573_1748947217478.20250603_183504.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929933261895842288
• Upwork Job ID: 1929933261895842288
• Last Price Increase: 2025-06-03
• Automatic offers:
• nkdengineer | Contributor | 107559973

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-03 14:32:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User B does not see Submit button in More menu.

What is the root cause of that problem?

We return false if user is not submitter or approver here

App/src/libs/ReportSecondaryActionUtils.ts

Lines 123 to 127 in 9e44461

	const isReportSubmitter = isCurrentUserSubmitter(report.reportID);
	const isReportApprover = isApproverUtils(policy, getCurrentUserAccountID());
	if (!isReportSubmitter && !isReportApprover) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We should allow submit action for admin or manager like we return true in here

    const isReportSubmitter = isCurrentUserSubmitter(report.reportID);
    const isReportApprover = isApproverUtils(policy, getCurrentUserAccountID());
    const isAdmin = policy?.role === CONST.POLICY.ROLE.ADMIN;
    const isManager = report.managerID === getCurrentUserAccountID();
    if (!isReportSubmitter && !isReportApprover && !isAdmin && !isManager) {
        return false;
    }

App/src/libs/ReportSecondaryActionUtils.ts

Lines 123 to 127 in 9e44461

	const isReportSubmitter = isCurrentUserSubmitter(report.reportID);
	const isReportApprover = isApproverUtils(policy, getCurrentUserAccountID());
	if (!isReportSubmitter && !isReportApprover) {
	return false;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add test for isSubmitAction to cover this case

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929933261895842288

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

We show the “Submit” action on the report preview, so we should show it in the secondary actions in the header as well when navigating to the expense report.

Screen.Recording.2025-06-04.at.2.24.44.PM.mov

We use this logic in the preview to show “Submit”:

App/src/libs/ReportPreviewActionUtils.ts

Line 63 in 625b425

return isExpense && (isSubmitter || isManager || isAdmin) && isOpen && isManualSubmitEnabled && !hasAnyViolations && !isAnyReceiptBeingScanned;

We should use the same logic here:

App/src/libs/ReportSecondaryActionUtils.ts

Lines 125 to 127 in 625b425

	if (!isReportSubmitter && !isReportApprover) {
	return false;
	}

as @nkdengineer suggested in his proposal. His proposal LGTM!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.