[Due for payment 2025-06-24] [$250] Wallet - Back button on the ‘Report physical card loss/damage’ page navigate to the wallet settings page instead of previous modal

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

1. Create an Expensify card in a workspace
2. Assign a physical card
3. Go to the Wallet page
4. Click on the card
5. Click on the assigned card
6. Click on the ‘Report physical card loss/damage’
7. Click on the header back button

Expected Result:

Navigate to previous modal (domain card modal)

Actual Result:

The modal is dismissed and we navigate to the wallet settings page.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mov

Recording.3123.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929957014151313904
• Upwork Job ID: 1929957014151313904
• Last Price Increase: 2025-06-03

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The modal is dismissed and we navigate to the wallet settings page.

What is the root cause of that problem?

In here, we use goBack function with route SETTING_WALLET

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Line 152 in 4510fc7

Navigation.goBack(ROUTES.SETTINGS_WALLET);

What changes do you think we should make in order to solve the problem?

We should call goBack function with SETTINGS_WALLET_DOMAIN_CARD route

    const handleBackButtonPress = () => {
        if (isReasonConfirmed) {
            setIsReasonConfirmed(false);
            return;
        }
        Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAIN_CARD.getRoute(cardID));
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Back button on the ‘Report physical card loss/damage’ page navigate to the wallet settings page instead of previous modal

What is the root cause of that problem?

handleBackButtonPress call Navigation.goBack(ROUTES.SETTINGS_WALLET) here

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Lines 146 to 153 in 4510fc7

	const handleBackButtonPress = () => {
	if (isReasonConfirmed) {
	setIsReasonConfirmed(false);
	return;
	}
	Navigation.goBack(ROUTES.SETTINGS_WALLET);
	};

What changes do you think we should make in order to solve the problem?

We can change the handleBackButtonPress function to use Navigation.goBack() without specifying a route to properly navigate back to the previous screen

    const handleBackButtonPress = () => {
        if (isReasonConfirmed) {
            setIsReasonConfirmed(false);
            return;
        }

        Navigation.goBack();
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A


What alternative solutions did you explore? (Optional)

[dukenv0307]

I had the proposal on Slack. I think @izarutskaya missed posting it here

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The modal is dismissed and we navigate to the wallet settings page.

What is the root cause of that problem?

Currently, when the user click to the header back button we will call goBack function with default value is SETTING_WALLET

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Lines 146 to 153 in ebcd248

	const handleBackButtonPress = () => {
	if (isReasonConfirmed) {
	setIsReasonConfirmed(false);
	return;
	}
	Navigation.goBack(ROUTES.SETTINGS_WALLET);
	};

What changes do you think we should make in order to solve the problem?

We should add routes SETTINGS_WALLET_DOMAIN_CARD as default value like we did here

    Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAIN_CARD.getRoute(cardID));

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Lines 146 to 153 in ebcd248

	const handleBackButtonPress = () => {
	if (isReasonConfirmed) {
	setIsReasonConfirmed(false);
	return;
	}
	Navigation.goBack(ROUTES.SETTINGS_WALLET);
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None UI bug

What alternative solutions did you explore? (Optional)

Or more simply we just need to call the function Navigation.goBack()

[izarutskaya]

Yes @dukenv0307, you are right, my apologies for mistake.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929957014151313904