[Due for payment 2025-07-01] [$250] Reports-After deleting IOU, nothing to show is shown briefly before updating to default page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+8@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1.Go to https://staging.new.expensify.com/home
2.Login with new expensifail account
3.Go to reports page
4. Tap fab - create expense and complete the flow with 1:1 user
5.Select and delete the expense
6. Note nothing to show is shown briefly before updating to default reports page

Expected Result:

After deleting IOU, nothing to show is must not be shown briefly before updating to default reports page

Actual Result:

After deleting IOU, nothing to show is shown briefly before updating to default reports page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6847113_1748663069259.Screenrecorder-2025-05-31-09-00-12-800.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929604557272309278
• Upwork Job ID: 1929604557272309278
• Last Price Increase: 2025-06-09
• Automatic offers:
• truph01 | Contributor | 107651410

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After deleting an IOU, a brief "Nothing to show" message is displayed before the app redirects to the default reports page. This creates a jarring and unnecessary visual flash.

What is the root cause of that problem?

• Once an expense is deleted, the hasResults flag remains true, so this condition is not satisfied:
  

  App/src/pages/Search/EmptySearchView.tsx

  Line 304 in e6e28de

  if (!hasResults) {

• As a result, the UI falls back to the "Nothing to show" fallback state:
  

  App/src/pages/Search/EmptySearchView.tsx

  Lines 337 to 338 in e6e28de

  	default:
  	return {

• Eventually, once the Search API is called again, hasResults is updated to false and the proper default reports page is displayed:
  

  App/src/pages/Search/EmptySearchView.tsx

  Lines 303 to 305 in e6e28de

  	case CONST.SEARCH.DATA_TYPES.INVOICE:
  	if (!hasResults) {
  	return {

• This delay in state update is the reason the "Nothing to show" message appears briefly after deleting an IOU.

What changes do you think we should make in order to solve the problem?

• We should enhance the condition that controls whether the default report page should be shown:

  Replace the check at:
  

  App/src/pages/Search/EmptySearchView.tsx

  Line 304 in e6e28de

  if (!hasResults) {

  With the following:

if (!hasResults || Object.values(transactions ?? {}).length === 0) {

• And ensure we are subscribing to the transactions collection from Onyx:

const [transactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {
    canBeMissing: true,
});

• This update ensures we check both the hasResults flag and whether there are any actual transactions in storage. This makes the fallback state more accurate and prevents the brief appearance of the "Nothing to show" screen.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting IOU, nothing to show is shown briefly before updating to default reports page

What is the root cause of that problem?

1. data.length = 0 so the following condition is true so EmptySearchView is displayed:
   

   App/src/components/Search/index.tsx

   Lines 520 to 531 in 4510fc7

   	if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type)) {
   	return (
   	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
   	<EmptySearchView
   	hash={hash}
   	type={type}
   	groupBy={groupBy}
   	hasResults={searchResults.search.hasResults}
   	/>
   	</View>
   	);
   	}

2. But because there is a race condition between data and searchResults.search.hasResults, hasResults is still true, causing the following condition to fallback to the default value:
   

   App/src/pages/Search/EmptySearchView.tsx

   Lines 269 to 270 in 4510fc7

   	case CONST.SEARCH.DATA_TYPES.EXPENSE:
   	if (!hasResults) {

   
   

   App/src/pages/Search/EmptySearchView.tsx

   Lines 337 to 344 in 4510fc7

   	default:
   	return {
   	headerMedia: LottieAnimations.GenericEmptyState,
   	title: translate('search.searchResults.emptyResults.title'),
   	subtitle: translate('search.searchResults.emptyResults.subtitle'),
   	headerContentStyles: [styles.emptyStateFolderWebStyles, StyleUtils.getBackgroundColorStyle(theme.emptyFolderBG)],
   	lottieWebViewStyles: {backgroundColor: theme.emptyFolderBG, ...styles.emptyStateFolderWebStyles},
   	};

What changes do you think we should make in order to solve the problem?

Make sure hasResults is calculated based on data.length as well:

App/src/components/Search/index.tsx

Line 527 in 4510fc7

hasResults={searchResults.search.hasResults}

hasResults={searchResults.search.hasResults && data.length > 0}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Christinadobrzyn]

I can't get into Browserstack to test this, but it seems to be reproducible based on the proposals. adding external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929604557272309278

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Christinadobrzyn]

@Ollyws can you please review the proposals when you have a moment? TY