[Due for payment 2025-06-24] [$250] Per diem - If per diem rate is saved as 20.61, it is saved as 21 but lists shows 20.61.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): applausetester+28@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Create Workspace - enable per diem rate - Import per diem rate
3. Open a destination with AFN currency or change currency to AFN
4. Tap amount
5. Enter amount in decimal like .67 and save

Expected Result:

If per diem rate is saved as 20.61, it must be saved as 20.61 as shown in lists.

Actual Result:

If per diem rate is saved as 20.61, it is saved as 21 but lists shows 20.61.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929615141786075049
• Upwork Job ID: 1929615141786075049
• Last Price Increase: 2025-06-09
• Automatic offers:
• mkzie2 | Contributor | 107616879

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-30 07:57:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

If per diem rate is saved as 20.61, it is saved as 21 but lists shows 20.61.

What is the root cause of that problem?

We used convertToFrontendAmountAsInteger to display the amount. For some currencies that don't have decimals, we round them up

App/src/libs/CurrencyUtils.ts

Lines 96 to 99 in 0035877

	function convertToFrontendAmountAsInteger(amountAsInt: number, currency: string = CONST.CURRENCY.USD): number {
	const decimals = getCurrencyDecimals(currency);
	return Number((Math.trunc(amountAsInt) / 100.0).toFixed(decimals));
	}

What changes do you think we should make in order to solve the problem?

Do not pass selectedRate?.currency here

App/src/pages/workspace/perDiem/WorkspacePerDiemDetailsPage.tsx

Line 47 in 7083c03

const amountValue = selectedSubRate?.rate ? convertToDisplayStringWithoutCurrency(Number(selectedSubRate.rate), selectedRate?.currency) : undefined;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[drminh2807]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per diem - If per diem rate is saved as 20.61, it is saved as 21 but lists shows 20.61.

What is the root cause of that problem?

Some currencies have no decimal

What changes do you think we should make in order to solve the problem?

1. Should use convertToDisplayStringWithoutCurrency instead
   

   App/src/pages/workspace/perDiem/EditPerDiemAmountPage.tsx

   Line 41 in f332a1e

   const defaultAmount = selectedSubrate?.rate ? convertToFrontendAmountAsString(Number(selectedSubrate.rate)) : undefined;

    const defaultAmount = selectedSubrate?.rate ? convertToDisplayStringWithoutCurrency(Number(selectedSubrate.rate), selectedRate?.currency) : undefined;

2. Should pass number of decimals to input instead default 2
   

   App/src/components/AmountWithoutCurrencyForm.tsx

   Lines 39 to 41 in f332a1e

   	if (!validateAmount(withLeadingZero, 2, CONST.IOU.AMOUNT_MAX_LENGTH, shouldAllowNegative)) {
   	return;
   	}

            if (!validateAmount(withLeadingZero, decimals, CONST.IOU.AMOUNT_MAX_LENGTH, shouldAllowNegative)) {
                return;
            }

3. Get decimals number from currency
   

   App/src/pages/workspace/perDiem/EditPerDiemAmountPage.tsx

   Lines 99 to 107 in f332a1e

   	<InputWrapper
   	ref={inputCallbackRef}
   	InputComponent={AmountWithoutCurrencyForm}
   	defaultValue={defaultAmount}
   	label={translate('workspace.perDiem.amount')}
   	accessibilityLabel={translate('workspace.perDiem.amount')}
   	inputID={INPUT_IDS.AMOUNT}
   	role={CONST.ROLE.PRESENTATION}
   	shouldAllowNegative

                 decimals={getCurrencyDecimals(selectedRate?.currency)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[github-actions]

⚠️ @drminh2807 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

@OfstadC Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929615141786075049

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)