[Due for payment 2025-06-19] [$250] Expense - In merged archived workspace, tapping add expense via report shows hmm not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9 1.53-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Use expensifail accounts to login
3. Login as User B & create a report in workspace
4. Login as User A and merge account with user B
5. Sign out as user A
6. Login as user B
7. Open archived chat
8. Tap add expense
9. Go to reports - expense reports
10. Tap on the expense

Expected Result:

In merged archived workspace, tapping add expense via report must not show hmm not here page
Deleted expense musnt beshown in expense reports page

Actual Result:

In merged archived workspace, tapping add expense via report shows hmm not here page
Deleted expense shown in expense reports page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6844410_1748430473546.Screenrecorder-2025-05-28-16-29-05-719.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928416627168624407
• Upwork Job ID: 1928416627168624407
• Last Price Increase: 2025-05-30
• Automatic offers:
• thelullabyy | Contributor | 107558261

Issue Owner

Current Issue Owner: @sonialiap / @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

Should the user be able to create an Expense or remove that option?

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - In merged archived workspace, tapping add expense via report shows hmm not here page

What is the root cause of that problem?

In a merged archived workspace, when tapping the Add Expense button, we are attempt to navigate to the page to create expense or to Add unreported expense. However, since the merged archived workspace (read-only), we got an error, and the page can't be accessed.

I haven’t investigated that as the backend logic in detail, but the issue on the FE is that users can still see and interact with the Add Expense button, even though the workspace is archived and should be read-only.

What changes do you think we should make in order to solve the problem?

We should not display the Add Expense button if the workspace is archived. This can be handled by checking the archived status and conditionally excluding the action.
Use the useReportIsArchived hook to check if the workspace (chat report) is archived:

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 461 in be60288

return getReportPreviewAction(violations, iouReport, policy, transactions, isIouReportArchived, reportActions, invoiceReceiverPolicy);

    const isChatReportArchived = useReportIsArchived(chatReport?.reportID);
...
//Then pass isChatReportArchived into getReportPreviewAction:
const reportPreviewAction = useMemo(() => {
        // It's necessary to allow payment animation to finish before button is changed
        if (isPaidAnimationRunning) {
            return CONST.REPORT.REPORT_PREVIEW_ACTIONS.PAY;
        }
        return getReportPreviewAction(violations, iouReport, policy, transactions, isIouReportArchived, reportActions, invoiceReceiverPolicy,isChatReportArchived);
    }, [isPaidAnimationRunning, violations, iouReport, policy, transactions, isIouReportArchived, reportActions, invoiceReceiverPolicy,isChatReportArchived]);

Update isAddExpenseAction in getReportPreviewAction to accept isChatReportArchived as a third parameter and return false if it's true.

App/src/libs/ReportPreviewActionUtils.ts

Line 213 in be60288

if (isAddExpenseAction(report, transactions ?? [])) {

    if (isAddExpenseAction(report, transactions ?? [],isChatReportArchived)) {
...
function isAddExpenseAction(report: Report, reportTransactions: Transaction[],isChatReportArchived?:boolean) {
    if(isChatReportArchived){
        return false
    }
    const isExpenseReport = isExpenseReportUtils(report);
    const isReportSubmitter = isCurrentUserSubmitter(report.reportID);
    const canAddTransaction = canAddTransactionUtil(report);

    return isExpenseReport && canAddTransaction && isReportSubmitter && reportTransactions.length === 0;
}

Note: We should apply the same logic to other areas that rely on getReportPrimaryAction and getReportPreviewAction, such as: MoneyReportHeader, ReportPreview

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should write unit tests to cover the case above that the Add expense is not displayed

What alternative solutions did you explore? (Optional)

We can confirm the expected behavior for the primary action: if the workspace is archived, we should return early with a default value in the primary action function to prevent showing any restricted actions

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928416627168624407