[Due for payment 2025-06-05] [$250] Expense - "Remove Hold" button becomes unresponsive after holding all expenses on a report.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+874@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace available.

1. Open the Expensify app.
2. Open any workspace chat.
3. Submit two different manual expenses.
4. Open the report of the just created expenses.
5. Long tap on one of the expenses.
6. Tap on "Hold" and complete the holding process.
7. Long tap on the other expense.
8. Tap on "Hold" and complete the holding process.
9. Note that a "Remove Hold" button appeared on top of the report.
10. Tap on "Remove Hold" button.
11. Note that no action is triggered after tapping on it.

Expected Result:

After tapping on "Remove Hold" all the expenses on the report, should be unheld automatically.

Actual Result:

After holding all the expenses on a report separatelly, the "Remove Hold" button on top of report, becomes unresponsive.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927248023823874300
• Upwork Job ID: 1927248023823874300
• Last Price Increase: 2025-06-03

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After holding all the expenses on a report separatelly, the "Remove Hold" button on top of report, becomes unresponsive.

What is the root cause of that problem?

The remove hold action on the expense report is designed for one transaction view and it does nothing if the transactionThreadReportID doesn't exist.

App/src/components/MoneyReportHeader.tsx

Lines 530 to 539 in 526a0e4

	onPress={() => {
	const parentReportAction = getReportAction(moneyRequestReport?.parentReportID, moneyRequestReport?.parentReportActionID);
	const moneyRequestAction = transactionThreadReportID ? requestParentReportAction : parentReportAction;
	if (!moneyRequestAction) {
	return;
	}
	changeMoneyRequestHoldStatus(moneyRequestAction);
	}}

In our case, the expense report isn't the combine report but the remove hold is still shown because we're paying all held expenses

App/src/libs/ReportPrimaryActionUtils.ts

Lines 289 to 291 in 526a0e4

	if (isRemoveHoldAction(report, reportTransactions) || isPayActionWithAllExpensesHeld) {
	return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
	}

App/src/libs/ReportPrimaryActionUtils.ts

Lines 210 to 219 in 526a0e4

	const transactionThreadReportID = getOneTransactionThreadReportID(report.reportID, reportActions);
	if (!transactionThreadReportID) {
	return false;
	}
	// Transaction is attached to expense report but hold action is attached to transaction thread report
	const isHolder = reportTransactions.some((transaction) => isHoldCreator(transaction, transactionThreadReportID));
	return isHolder;

What changes do you think we should make in order to solve the problem?

As we're doing the Remove hold action on the expense report for only combined report case, we should only show the remove hold action if it's combined report. We can add transactionThreadReportID check here

const transactionThreadReportID = getOneTransactionThreadReportID(report.reportID, reportActions);
if (isRemoveHoldAction(report, reportTransactions) || (isPayActionWithAllExpensesHeld && transactionThreadReportID)) {
    return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
}

App/src/libs/ReportPrimaryActionUtils.ts

Lines 289 to 291 in 526a0e4

	if (isRemoveHoldAction(report, reportTransactions) || isPayActionWithAllExpensesHeld) {
	return CONST.REPORT.PRIMARY_ACTIONS.REMOVE_HOLD;
	}

Or we can move all logic into isRemoveHoldAction function.

App/src/libs/ReportPrimaryActionUtils.ts

Lines 210 to 219 in 526a0e4

	const transactionThreadReportID = getOneTransactionThreadReportID(report.reportID, reportActions);
	if (!transactionThreadReportID) {
	return false;
	}
	// Transaction is attached to expense report but hold action is attached to transaction thread report
	const isHolder = reportTransactions.some((transaction) => isHoldCreator(transaction, transactionThreadReportID));
	return isHolder;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update ReportPrimaryActionUtils test to verify the Remove hold action isn't returned if the expense report isn't combined report.

What alternative solutions did you explore? (Optional)

We can handle remove hold all held expenses by getting all created iou actions belong with the expense report and call changeMoneyRequestHoldStatus for each action.

App/src/components/MoneyReportHeader.tsx

Lines 530 to 539 in 526a0e4

	onPress={() => {
	const parentReportAction = getReportAction(moneyRequestReport?.parentReportID, moneyRequestReport?.parentReportActionID);
	const moneyRequestAction = transactionThreadReportID ? requestParentReportAction : parentReportAction;
	if (!moneyRequestAction) {
	return;
	}
	changeMoneyRequestHoldStatus(moneyRequestAction);
	}}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927248023823874300

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)