[Ready for payment] [$250] Expense - Remove hold option shows up for recipient after paying the pending amount

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sdnoisoisdnsiosd1211@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Send two expenses to User B.
3. [User A] Click on the expense preview to go to expense preview.
4. [User A] Right click on any expense > Hold.
5. [User A] Enter reason and save it.
6. [User B] Open 1:1 DM with User A.
7. [User B] Click Pay elsewhere on the expense preview.
8. [User B] Pay the pending (unheld) amount only.
9. [User B] Click on the held expense.
10. [User B] Click Remove hold.

Expected Result:

Remove hold option should not show up for User B because User B is a recipient.

Actual Result:

Remove hold option shows up for User B after paying the pending amount.
When removing hold, error "Unexpected error taking this expense off hold. Please try again later." shows up, but the expense is unheld successfully.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937262064082524474
• Upwork Job ID: 1937262064082524474
• Last Price Increase: 2025-07-14
• Automatic offers:
• QichenZhu | Reviewer | 108118113

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the Payer unholds the transaction, in which payee holder, if the unholding fails for whatever reason, the frontend shouldn't optimistically show the expense as successfully unheld.

What is the root cause of that problem?

For whatever reason, unhold fails, we set an error in the transaction failure data, but do not update the failure data to show the Remove Hold again.

App/src/libs/actions/IOU.ts

Lines 11081 to 11088 in be6876c

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: {
	pendingAction: null,
	errors: getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericUnholdExpenseFailureMessage'),
	},
	},

What changes do you think we should make in order to solve the problem?

We should update the failureData to show the expense is unheld successfully, and not show the pay button if it fails.

  {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
            value: {
                pendingAction: null,
                errors: getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericUnholdExpenseFailureMessage'),
                comment: {
                    hold: transaction?.comment?.hold,
                },
            },
        },

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[RachCHopkins]

@vincdargento can you please confirm

[User A] Send two expenses to User B

Does this mean via DM i.e. as an IOU?

[vincdargento]

Does this mean via DM i.e. as an IOU?

@RachCHopkins Yes, in 1:1 DM

[RachCHopkins]

@vincdargento Should DMs have Hold functionality? I'll check on this.

[melvin-bot]

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[RachCHopkins]

Checking with Robert.

[RachCHopkins]

Ok, confirmed that DMs do indeed have Hold.