[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] WS Chat - After deleting an expense, it navigates to different chat instead of the main chat

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.49-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+bm588@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web
App Component: Chat Report View

Action Performed:

Precondition -
Use Expensifail account

1. Go to https://staging.new.expensify.com/
2. As user A, create a workspace and add user B as a member
3. As user B, go to the WS chat and create an expense
4. As user A, go to the WS chat of user B and open the expense
5. As user B, delete the expense

Expected Result:

After user B deletes the expense, user A should navigate back to the main chat

Actual Result:

After user B deletes the expense, user A navigates to another chat.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6839050_1747905917576.bandicam_2025-05-22_12-11-56-830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021926946552701025730
• Upwork Job ID: 1926946552701025730
• Last Price Increase: 2025-05-26

Issue Owner

Current Issue Owner: @flaviadefaria

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After user B deletes the expense, user A navigates to another chat.

What is the root cause of that problem?

• When the app receives an event from the server and calls a navigate command here:
  

  App/src/pages/home/ReportScreen.tsx

  Line 630 in 526a0e4

  Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));

• If the persistence mechanism (which saves the navigation state) is in the middle of rehydration, the previously saved state will be applied once rehydration completes. This process overrides the new navigation command triggered by the server, causing the navigator to revert to its initial route.

What changes do you think we should make in order to solve the problem?

• Ensure the navigate command is executed only if Navigation.isNavigationReady() ready:
  

  App/src/pages/home/ReportScreen.tsx

  Line 630 in 526a0e4

  Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));

Navigation.isNavigationReady().then(() => {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result:

bandicam.2025-05-25.09-12-26-930.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021926946552701025730

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[flaviadefaria]

Added the external label.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After user B deletes an expense, user A is incorrectly navigated to a different chat.

What is the root cause of that problem?

• When an expense is deleted, three navigation actions are triggered sequentially:

  • App/src/pages/home/ReportScreen.tsx

    Line 620 in f431f8c

    Navigation.dismissModal();

  • App/src/pages/home/ReportScreen.tsx

    Line 623 in f431f8c

    Navigation.popToSidebar();

  • App/src/pages/home/ReportScreen.tsx

    Line 631 in f431f8c

    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));

• The second navigation is delayed until Navigation.isNavigationReady() resolves. This causes the navigation actions to execute in the following order: first > third > second, instead of the intended sequence.

• This out-of-order execution leads to incorrect navigation. For example, consider the following screen stack on user A’s side (after step 4 in OP):

STACK
└── ReportsSplitNavigator
    └── STACK
        ├── Home
        ├── Report Screen (A) - Another report
        ├── Report Screen (B) - Policy expense chat
        └── Report Screen (C) - Expenses chat

• Step-by-step behavior:
  1. The first navigation action is a no-op since there’s no modal to dismiss.
  2. The third navigation pushes the parent report (Report B), resulting in:

STACK
└── ReportsSplitNavigator
    └── STACK
        ├── Home
        ├── Report Screen (A) - Another report
        ├── Report Screen (B) - Policy expense chat
        ├── Report Screen (C) - Expenses chat
        └── Report Screen (B) - Policy expense chat

3. The second navigation action (delayed by Navigation.isNavigationReady()) then calls popToTop, collapsing the stack to:

STACK
└── ReportsSplitNavigator
    └── STACK
        ├── Home
        └── Report Screen (A) - Another report

• This unintended popToTop causes the user to be redirected away from the expected screen.

What changes do you think we should make in order to solve the problem?

• The call to Navigation.isNavigationReady() was added in this PR to ensure safe navigation when the RHP is open.

• However, in the scenario where no RHP is open, wrapping popToSidebar() in Navigation.isNavigationReady() causes unnecessary delay and incorrect order of operations.

• We should update the logic at lines 622–624 to the following:

if (isReportDetailOpenInRHP) {
    Navigation.isNavigationReady().then(() => {
        Navigation.popToSidebar();
    });
} else {
    Navigation.popToSidebar();
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

• An extended version of the solution involves refining the broader navigation block starting from line 621:

if (Navigation.getTopmostReportId() === prevOnyxReportID) {
    if (isReportDetailOpenInRHP) {
        Navigation.isNavigationReady().then(() => {
            Navigation.popToSidebar();
        });
    } else {
        Navigation.popToSidebar();
    }
}
if (prevReport?.parentReportID) {
    // Prevent navigation to the IOU/Expense Report if it is pending deletion.
    if (isMoneyRequestReportPendingDeletion(prevReport.parentReportID)) {
        return;
    }
    if (isReportDetailOpenInRHP) {
        Navigation.isNavigationReady().then(() => {
                        InteractionManager.runAfterInteractions(() => {
                            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
                        });
        });
    } else {
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
    }
    return;
}
if (isReportDetailOpenInRHP) {
    Navigation.isNavigationReady().then(() => {
        InteractionManager.runAfterInteractions(() => {
            navigateToConciergeChat();
        });
    });
} else {
    navigateToConciergeChat();
}