[Due for payment 2025-06-02] [$250] Move expense - Expense can be moved to report of deleted workspace

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): dhsishdsiushbishd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace chat.
4. Submit an expense to the workspace chat.
5. Delete the workspace.
6. Create another workspace.
7. Go to workspace chat.
8. Submit an expense to the workspace chat.
9. Click on the expense preview.
10. Click More > Move expense.
11. Select the expense report of the deleted workspace.

Expected Result:

Expense report from the deleted workspace should not appear in the Report list when moving expense.
Reports from other workspaces should not appear in the Report list (production behavior).

Actual Result:

Expense report from the deleted workspace appears in the Report list when moving expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925500566534762869
• Upwork Job ID: 1925500566534762869
• Last Price Increase: 2025-05-22
• Automatic offers:
• nkdengineer | Contributor | 107407062

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report from the deleted workspace appears in the Report list when moving expense.

What is the root cause of that problem?

It comes from #62270. But the current problem is isReportOutstanding function doesn't return false for archived reports.

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Lines 53 to 67 in 6871ba9

	const expenseReports = useMemo(
	() =>
	Object.values(allPoliciesID ?? {}).flatMap((policyID) => {
	if (!policyID) {
	return [];
	}
	const reports = getOutstandingReportsForUser(policyID, currentUserPersonalDetails.accountID, allReports ?? {});
	return reports;
	}),
	[allPoliciesID, allReports, currentUserPersonalDetails.accountID],
	);
	const reportOptions: ReportListItem[] = useMemo(() => {
	if (!allReports) {
	return [];

App/src/libs/ReportUtils.ts

Lines 9640 to 9647 in 6871ba9

	function getOutstandingReportsForUser(policyID: string | undefined, reportOwnerAccountID: number | undefined, reports: OnyxCollection<Report> = allReports): Array<OnyxEntry<Report>> {
	if (!reports) {
	return [];
	}
	return Object.values(reports)
	.filter((report) => isReportOutstanding(report, policyID) && report?.ownerAccountID === reportOwnerAccountID)
	.sort((a, b) => a?.reportName?.localeCompare(b?.reportName?.toLowerCase() ?? '') ?? 0);
	}

App/src/libs/ReportUtils.ts

Lines 9618 to 9630 in 6871ba9

	function isReportOutstanding(iouReport: OnyxInputOrEntry<Report>, policyID: string | undefined): boolean {
	if (!iouReport || isEmptyObject(iouReport)) {
	return false;
	}
	return (
	isExpenseReport(iouReport) &&
	iouReport?.stateNum !== undefined &&
	iouReport?.statusNum !== undefined &&
	iouReport?.policyID === policyID &&
	iouReport?.stateNum <= CONST.REPORT.STATE_NUM.SUBMITTED &&
	iouReport?.statusNum <= CONST.REPORT.STATUS_NUM.SUBMITTED &&
	!hasForwardedAction(iouReport.reportID)
	);

What changes do you think we should make in order to solve the problem?

We should return false for archived report here

const reportNameValuePair = allReportNameValuePair?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${iouReport.reportID}`] ?? {};

return (
    isExpenseReport(iouReport) &&
    iouReport?.stateNum !== undefined &&
    iouReport?.statusNum !== undefined &&
    iouReport?.policyID === policyID &&
    iouReport?.stateNum <= CONST.REPORT.STATE_NUM.SUBMITTED &&
    iouReport?.statusNum <= CONST.REPORT.STATUS_NUM.SUBMITTED &&
    !hasForwardedAction(iouReport.reportID) && 
    !isArchivedReport(reportNameValuePair)
);

App/src/libs/ReportUtils.ts

Lines 9618 to 9630 in 6871ba9

	function isReportOutstanding(iouReport: OnyxInputOrEntry<Report>, policyID: string | undefined): boolean {
	if (!iouReport || isEmptyObject(iouReport)) {
	return false;
	}
	return (
	isExpenseReport(iouReport) &&
	iouReport?.stateNum !== undefined &&
	iouReport?.statusNum !== undefined &&
	iouReport?.policyID === policyID &&
	iouReport?.stateNum <= CONST.REPORT.STATE_NUM.SUBMITTED &&
	iouReport?.statusNum <= CONST.REPORT.STATUS_NUM.SUBMITTED &&
	!hasForwardedAction(iouReport.reportID)
	);

Or we can filter out it here

App/src/libs/ReportUtils.ts

Lines 9640 to 9647 in 6871ba9

	function getOutstandingReportsForUser(policyID: string | undefined, reportOwnerAccountID: number | undefined, reports: OnyxCollection<Report> = allReports): Array<OnyxEntry<Report>> {
	if (!reports) {
	return [];
	}
	return Object.values(reports)
	.filter((report) => isReportOutstanding(report, policyID) && report?.ownerAccountID === reportOwnerAccountID)
	.sort((a, b) => a?.reportName?.localeCompare(b?.reportName?.toLowerCase() ?? '') ?? 0);
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update getOutstandingReportsForUser test and verify the result doesn't include the archived report.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.