[Due for payment 2025-06-11] [$250] tags-User able to delete all tags.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9 1.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #58052
Email or phone of affected tester (no customers): slottwo1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Workspace Settings

Action Performed:

1. Launch app
2. Create a new workspace and enable tags
3. Tap Tags
4. Add a tag
5. Tap settings - enable members must tag all expenses
6. Delete the tag

Expected Result:

User must not be able to delete all tags. Cannot delete all tags modal must be shown.

Actual Result:

User able to delete all tags and Cannot delete all tags modal is not shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6838761_1747870155789.Screenrecorder-2025-05-22-04-55-18-872.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927373792094838117
• Upwork Job ID: 1927373792094838117
• Last Price Increase: 2025-05-27
• Automatic offers:
• nkdengineer | Contributor | 107474659

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ijmalik]

Hi @sakluger

The issue has been resolved in v9.1.49-4.

62537.mp4

[mitarachim]

QA team still reproduce this issue using build v9.1.49-4

Screenrecorder-2025-05-22-09-01-38-592.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User able to delete all tags and Cannot delete all tags modal is not shown.

What is the root cause of that problem?

When we update requiresTag, we only update required in policy tags data if the the tags are multi-level tag

App/src/libs/actions/Policy/Tag.ts

Lines 785 to 803 in 6871ba9

	if (isMultiLevelTags) {
	const getUpdatedTagsData = (required: boolean): OnyxUpdate => ({
	key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
	onyxMethod: Onyx.METHOD.MERGE,
	value: {
	...Object.keys(policyTags).reduce<PolicyTagLists>((acc, key) => {
	acc[key] = {
	...acc[key],
	required,
	};
	return acc;
	}, {}),
	},
	});
	onyxData.optimisticData?.push(getUpdatedTagsData(requiresTag));
	onyxData.failureData?.push(getUpdatedTagsData(!requiresTag));
	onyxData.successData?.push(getUpdatedTagsData(requiresTag));
	}

Then isDisablingOrDeletingLastEnabledTag returns false when we select all tags, it's only updated until the tag list is updated from the backend with required as true

App/src/libs/OptionsListUtils.ts

Lines 1141 to 1150 in 6871ba9

	function isDisablingOrDeletingLastEnabledTag(policyTagList: PolicyTagList | undefined, selectedTags: Array<PolicyTag | undefined>): boolean {
	const enabledTagsCount = getCountOfEnabledTagsOfList(policyTagList?.tags);
	if (!enabledTagsCount) {
	return false;
	}
	if (policyTagList?.required && selectedTags.filter((selectedTag) => selectedTag?.enabled).length === enabledTagsCount) {
	return true;
	}

What changes do you think we should make in order to solve the problem?

We should also update required as true for normal tags. We can remove isMultiLevelTags check here since normal tags are also objects with tag names like multi-level tags.

App/src/libs/actions/Policy/Tag.ts

Lines 785 to 803 in 6871ba9

	if (isMultiLevelTags) {
	const getUpdatedTagsData = (required: boolean): OnyxUpdate => ({
	key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
	onyxMethod: Onyx.METHOD.MERGE,
	value: {
	...Object.keys(policyTags).reduce<PolicyTagLists>((acc, key) => {
	acc[key] = {
	...acc[key],
	required,
	};
	return acc;
	}, {}),
	},
	});
	onyxData.optimisticData?.push(getUpdatedTagsData(requiresTag));
	onyxData.failureData?.push(getUpdatedTagsData(!requiresTag));
	onyxData.successData?.push(getUpdatedTagsData(requiresTag));
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update setPolicyRequiresTag test and verify that required is updated to true for normal tags.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@sakluger Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927373792094838117