[Due for payment 2025-05-30] [$250] [Test] OnyxDerivedTest not working as expected

[kacper-mikolajczak]

Summary

OnyxDerivedTest are giving false positive results.

Action Performed:

1. Add crashing assertion to any of OnyxDerivedTest tests: `expect(1).toBe(2)
2. Run npm run test -- OnyxDerivedTest

Expected Result:

Test that was supplied with crashing assertion should fail

Actual Result:

All tests passed

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021923022935652145824
• Upwork Job ID: 1923022935652145824
• Last Price Increase: 2025-06-07

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kacper-mikolajczak]

CC @TMisiukiewicz @hoangzinh

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tests in OnyxDerivedTest are giving false-positive results — they appear to pass even when a clearly failing assertion like expect(1).toBe(2) is added. This gives the false impression that the test logic is correct when it may not even be executing.

What is the root cause of that problem?

Several tests use waitForBatchedUpdates().then(...) without properly awaiting the returned promise. Because Jest does not wait for these promises to resolve, any assertions inside them are never executed. As a result, even failing assertions do not cause the test to fail, and Jest incorrectly reports the test as passed.

What changes do you think we should make in order to solve the problem?

We should refactor all affected tests to use async/await syntax instead of .then(...) chaining. Specifically, convert the test functions to async, await the waitForBatchedUpdates() call, and then perform the remaining logic and assertions. This ensures Jest waits for the entire async test body before considering the test complete. example change

  it('returns empty reports when dependencies are not set', async () => {
            await waitForBatchedUpdates();

            const derivedReportAttributes = await OnyxUtils.get(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES);
            expect(derivedReportAttributes).toEqual({
                reports: {},
                locale: null,
            });
        });

We can apply the suggested change in the following places: here, here, and here.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[hoangzinh]

Hi @kacper-mikolajczak, will you work on this issue or someone else?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021923022935652145824

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)