[Due for payment 2025-05-22] [Better Expense Report View] No RBR on the expense preview in the main chat when payment fails

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.41-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sd89ns@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Submit an expense to the user.
4. Go to Account > Preferences.
5. Click Payment currency.
6. Change the currency to another currency.
7. As the recipient, open 1:1 DM with the sender.
8. Click Pay elsewhere on the expense preview.
9. Note that there is no RBR on the expense preview in the main chat when payment fails.
10. Repeat Step 1 to 9 using Gmail account as the recipient. There will be RBR on the expense preview when payment fails.

Expected Result:

When payment fails, there should be a RBR on the expense preview in the main chat (current implementation with Gmail accounts).

Actual Result:

When payment fails, there is no RBR on the expense preview in the main chat.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6824112_1746611961987.20250507_175420.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-07 11:10:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When payment fails, there is no RBR on the expense preview in the main chat.

What is the root cause of that problem?

In old version, we are checking hasErrors with hasActionsWithErrors(iouReportID) in ReportPreviewOld component here

App/src/components/ReportActionItem/ReportPreviewOld.tsx

Line 403 in fdc8093

const shouldShowRBR = hasErrors && !iouSettled;

App/src/components/ReportActionItem/ReportPreviewOld.tsx

Lines 240 to 247 in fdc8093

	const hasErrors =
	(hasMissingSmartscanFields && !iouSettled) ||
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	hasViolations(iouReportID, violations, true) ||
	hasNoticeTypeViolations(iouReportID, violations, true) ||
	hasWarningTypeViolations(iouReportID, violations, true) ||
	(isReportOwner(iouReport) && hasReportViolations(iouReportID)) ||
	hasActionsWithErrors(iouReportID);

And in a beta, we don't check this error => No RBR on the expense preview in the main

App/src/libs/TransactionPreviewUtils.ts

Line 307 in fdc8093

const shouldShowRBR = hasAnyViolations || hasErrorOrOnHold;

What changes do you think we should make in order to solve the problem?

1. We should add hasActionsWithErrors(iouReportID) to the condition or we can add this in hasAnyViolations

    const shouldShowRBR = hasAnyViolations || hasErrorOrOnHold || hasActionsWithErrors(iouReport?.reportID);

App/src/libs/TransactionPreviewUtils.ts

Line 307 in fdc8093

const shouldShowRBR = hasAnyViolations || hasErrorOrOnHold;

2. We can discuss whether we should add RBR message and if so we can add it here

App/src/libs/TransactionPreviewUtils.ts

Lines 171 to 183 in fdc8093

	let RBRMessage: TranslationPathOrText | undefined;
	if (!shouldShowRBR || !transaction) {
	RBRMessage = {text: ''};
	}
	if (shouldShowHoldMessage && RBRMessage === undefined) {
	RBRMessage = {translationPath: 'iou.expenseWasPutOnHold'};
	}
	if (violationMessage && RBRMessage === undefined) {
	RBRMessage = getViolationTranslatePath(violations, hasFieldErrors, violationMessage);
	}

Note: We should double check the shouldShowRBR condition in both versions to ensure consistency.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[allgandalf]

@laurenreidexpensify please assign me here, this belongs to better expense preview project, AFAIR @JakubKorytko was working on this one and we were going to fix it later (sorry @JakubKorytko if it wasn't you). but lets track this one @mountiny @trjExpensify

[JakubKorytko]

Worked a bit on RBR in BERV, so you may be right, I can take a look tomorrow.