[$250] [Due for payment 2025-05-14] [Due for payment 2025-05-14] Track expense - Incomplete email can be selected when sharing track expense to accountant

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #58402
Email or phone of affected tester (no customers): sjdoisdmjoisdjos@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has no workspace.
• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Submit a track expense.
4. Click Share it with my accountant.
5. Enter an incomplete email (without @gmail.com).
6. Select the email.
7. On confirmation page, enter merchant and click Create expense.

Expected Result:

In Step 5, incomplete email should not be allowed to select when submitting track expense.

Actual Result:

In Step 5, incomplete email is allowed to select when submitting track expense.
In Step 7, after selecting incomplete email and submitting track expense, app shows not here page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021923112545216469664
• Upwork Job ID: 1923112545216469664
• Last Price Increase: 2025-05-15

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incomplete email can be selected when sharing track expense to accountant

What is the root cause of that problem?

This happen due to here we pass shouldAcceptName: true

App/src/pages/iou/request/MoneyRequestAccountantSelector.tsx

Lines 99 to 103 in f867903

	const newOptions = filterAndOrderOptions(defaultOptions, debouncedSearchTerm, {
	excludeLogins: CONST.EXPENSIFY_EMAILS_OBJECT,
	maxRecentReportsToShow: CONST.IOU.MAX_RECENT_REPORTS_TO_SHOW,
	shouldAcceptName: true,
	});

that cause the search input to be any string value causing to pass invalid email

App/src/libs/OptionsListUtils.ts

Line 1365 in f867903

* - If prop shouldAcceptName = true, the searchValue can be also a normal string

What changes do you think we should make in order to solve the problem?

We should remove shouldAcceptName: true

Here

App/src/pages/iou/request/MoneyRequestAccountantSelector.tsx

Lines 99 to 103 in f867903

	const newOptions = filterAndOrderOptions(defaultOptions, debouncedSearchTerm, {
	excludeLogins: CONST.EXPENSIFY_EMAILS_OBJECT,
	maxRecentReportsToShow: CONST.IOU.MAX_RECENT_REPORTS_TO_SHOW,
	shouldAcceptName: true,
	});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.