[$250] Web - Workspace settings page can be accessible after workspace has been deleted offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.38-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Go offline
4. Go to any workspace page (i.e. workspace members, invite members, workspace invite message) and copy the URL in browser
5. Delete that workspace
6. Paste and send the URL in any chat
7. Click on the URL in the chat

Expected Result:

The not found page gets displayed

Actual Result:

Workspace settings page is accessible after deletion while offline

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6804422_1744848275691.bandicam_2025-04-17_02-56-32-440.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919211410795310824
• Upwork Job ID: 1919211410795310824
• Last Price Increase: 2025-05-05

Issue Owner

Current Issue Owner: @Gonals

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-01 14:50:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Workspace settings page can be accessible after workspace has been deleted offline

What is the root cause of that problem?

we pass shouldShowPendingDeletePolicy as isOffline here

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 163 in 3191948

const shouldShowPolicy = useMemo(() => shouldShowPolicyUtil(policy, isOffline, currentUserLogin), [policy, isOffline, currentUserLogin]);

so pending delete policies are considered as should show policy while offline

What changes do you think we should make in order to solve the problem?

We should pass shouldShowPendingDeletePolicy as false

    const shouldShowPolicy = useMemo(() => shouldShowPolicyUtil(policy, false, currentUserLogin), [policy, isOffline, currentUserLogin]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[bernhardoj]

Pulling my proposal from #56694 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

User can access deleted WS page while offline.

What is the root cause of that problem?

It was supposed to be fixed by #55579, but it looks like some conflict kinda 'reverted' the fix. The cause of the issue is that we allow a pending delete workspace to show when offline (the isOffline param)

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 387 in 223a34c

const shouldShowPolicy = useMemo(() => checkIfShouldShowPolicy(policy, isOffline, currentUserLogin), [policy, isOffline, currentUserLogin]);

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 163 in 223a34c

const shouldShowPolicy = useMemo(() => shouldShowPolicyUtil(policy, isOffline, currentUserLogin), [policy, isOffline, currentUserLogin]);

What changes do you think we should make in order to solve the problem?

We should change the shouldShowPendingDeletePolicy param to false again.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Render both WorkspaceInitialPage and WorkspacePageWithSections given a pending delete policy while offline, and verify that the not found page is shown.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919211410795310824

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[alexpensify]

@allroundexperts, when you get a chance, can you please review whether this proposal will fix the issue? Thanks!