[Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+cnmnmc2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to expense report.
5. Send a message.
6. Right click on the message > Reply in thread.
7. Click on the link under header subtitle.

Expected Result:

The message should be highlighted after returning from thread via header subtitle link.

Actual Result:

The message is not highlighted after returning from thread via header subtitle link.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6811112_1745446853109.20250424_061612.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021918492381793855544
• Upwork Job ID: 1918492381793855544
• Last Price Increase: 2025-05-03
• Automatic offers:
• ikevin127 | Reviewer | 107178477
• mkzie2 | Contributor | 107178478

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The message is not highlighted after returning from thread via header subtitle link.

What is the root cause of that problem?

We do not pass linkedReportActionID to indicate the current highlighted message like we did with regular ReportActionsList

App/src/pages/home/report/ReportActionsList.tsx

Line 163 in 43fec36

const route = useRoute<PlatformStackRouteProp<ReportsSplitNavigatorParamList, typeof SCREENS.REPORT>>();

App/src/pages/home/report/ReportActionsList.tsx

Line 187 in 43fec36

const linkedReportActionID = route?.params?.reportActionID;

What changes do you think we should make in order to solve the problem?

In MoneyRequestReportActionsList, get linkedReportActionID and pass to ReportActionsListItemRenderer just like what we did with ReportActionsList

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

None

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[stephanieelliott]

Hm, I'm not sure I understanding what the issue is -- I think this is expected behavior? I would expect that highlighting text would not persist after clicking another link

[mkzie2]

@stephanieelliott "Highlight" here refers to the active message. For example when you go back from a thread report, it should focus/highlight the parent message where the thread was started from:

Screen.Recording.2025-04-29.at.15.16.17.mov

In the issue OP, this highlighting mechanism did not work in Search screen.

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Got it, makes more sense now -- thanks for explaining that @mkzie2!