[Due for payment 2025-05-14] [$250] Web - To field has a hover effect but it is not clickable

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Sign up with a new account and select "Track expense" onboarding option so that the account can have a self DM
3. Open self DM and create an expense
4. Select "Submit it to someone" from the whisper actions
5. Hover on the "To" field

Expected Result:

There is no hover effect

Actual Result:

To field has a hover effect even if it is not clickable

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6804282_1744839796034.bandicam_2025-04-17_00-38-00-973.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915752189635262981
• Upwork Job ID: 1915752189635262981
• Last Price Increase: 2025-04-25
• Automatic offers:
• nkdengineer | Contributor | 107097408

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

To field has a hover effect even if it is not clickable

What is the root cause of that problem?

isInteractive is undefined then we still have the hover effect, the hover effect is only disabled if isInteractive is false. It's fixed previously but happens again after this PR

App/src/components/MoneyRequestConfirmationList.tsx

Lines 740 to 741 in 3088b0f

	isInteractive: isCreateExpenseFlow && !isTestReceipt,
	shouldShowRightIcon: isCreateExpenseFlow && !isTestReceipt,

What changes do you think we should make in order to solve the problem?

To be safe, we should cast isCreateExpenseFlow to boolean

const isCreateExpenseFlow = !!transaction?.isFromGlobalCreate && !isPerDiemRequest;

App/src/components/MoneyRequestConfirmationList.tsx

Line 262 in 3088b0f

const isCreateExpenseFlow = transaction?.isFromGlobalCreate && !isPerDiemRequest;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915752189635262981

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[shubham1206agra]

@nkdengineer's proposal looks good to me.

🎀👀🎀 C+ reviewed