[$125] Reports-RHP loads infinitely after deleting expense in report that has deleted expense with reply

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sdjsjndusdjsiudsd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace chat.
4. Submit two expenses.
5. Go to transaction thread of the second expense.
6. Send a message.
7. Delete the expense that has message in Step 6.
8. Go to Reports.
9. Go to Expense Reports.
10. Click on the remaining expense from Step 4.
11. Right click on the expense preview.
12. Click Delete expense.
13. Delete the expense.

Expected Result:

RHP will dismiss after the expense is deleted.

Actual Result:

RHP loads infinitely after deleting the expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bandicam.2025-04-22.11-44-46-776.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021914766250605962251
• Upwork Job ID: 1914766250605962251
• Last Price Increase: 2025-05-29
• Automatic offers:
• ishakakkad | Contributor | 107374739

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

@jponikarchuk I think you sent a video that is related to another bug

[jponikarchuk]

@Eskalifer1 Just edited, sorry

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user deletes all expenses from a report—especially one where a previous expense had a message associated with it—the Right Hand Panel (RHP) does not dismiss as expected. Instead, it enters an infinite loading state.

What is the root cause of that problem?

After deleting the last remaining expense from a report, the reportOnyx object becomes empty. However, there is no logic in place to handle this edge case in ReportScreen.tsx, so the RHP continues trying to render a report that no longer exists, resulting in infinite loading.

This is especially problematic when:

• An expense had messages tied to it (e.g., from a transaction thread).
• The user navigates through multiple steps, including deleting expenses directly from the RHP.

What changes do you think we should make in order to solve the problem?

We should monitor changes to reportOnyx, and when:

• reportOnyx becomes an empty object, and
• the Onyx data status is loaded,

const [reportOnyx, reportOnyxResult] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportIDFromRoute}`, {allowStaleData: true});

const handleBackButtonPress = useCallback(() => {
    if (isInNarrowPaneModal && backTo !== SCREENS.SEARCH.REPORT_RHP) {
        Navigation.dismissModal();
        return;
    }
    if (backTo) {
        Navigation.goBack(backTo as Route, {shouldPopToTop: true});
        return;
    }
    Navigation.goBack(undefined, {shouldPopToTop: true});
}, [isInNarrowPaneModal, backTo]);

Inside useEffect

useEffect(() => {
     if ((reportOnyx && Object.keys(reportOnyx).length > 0) ?? reportOnyxResult.status === 'loading') {
            return;
        }

    handleBackButtonPress();
}, [reportOnyx, reportOnyxResult]);

we should trigger dismissal of the RHP. This will ensure that the user isn’t left staring at a loading spinner for a report that no longer exists.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

I can reproduce based on the steps in the OP - I'm not sure if this needs to be internal - we'll start external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021914766250605962251

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)