Skip to content

Clean up the ownerAccountID in the canModifyTask method #60447

Description

@tgolen

cc @Krishna2323 this was another cleanup that I found

Problem

canModifyTask has a third argument for ownerAccountID but nothing is ever passing that argument. Instead, the canModifyTask is getting the data from getTaskOwnerAccountID(). This presents several problems:

  1. The argument is useless
  2. getTaskOnwerAccountID() is only doing return taskReport?.ownerAccountID; which seems like not really worth having a method for

Solution

  • Remove the third argument from canModifyTask()
  • Replace all calls to getTaskOnwerAccountID() with report?.ownerAccountID

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions