cc @Krishna2323 this was another cleanup that I found
Problem
canModifyTask has a third argument for ownerAccountID but nothing is ever passing that argument. Instead, the canModifyTask is getting the data from getTaskOwnerAccountID(). This presents several problems:
- The argument is useless
getTaskOnwerAccountID() is only doing return taskReport?.ownerAccountID; which seems like not really worth having a method for
Solution
- Remove the third argument from
canModifyTask()
- Replace all calls to
getTaskOnwerAccountID() with report?.ownerAccountID
cc @Krishna2323 this was another cleanup that I found
Problem
canModifyTaskhas a third argument forownerAccountIDbut nothing is ever passing that argument. Instead, thecanModifyTaskis getting the data fromgetTaskOwnerAccountID(). This presents several problems:getTaskOnwerAccountID()is only doingreturn taskReport?.ownerAccountID;which seems like not really worth having a method forSolution
canModifyTask()getTaskOnwerAccountID()withreport?.ownerAccountID