[Due for payment 2025-04-30] [$250] Android - Save button overlaps the zoom slider when setting workspace picture

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Tecno spark 20/ Android 13
App Component: Workspace Settings

Action Performed:

1. Open the Hybrid app
2. Navigate to Account settings > Workspace
3. Create a new workspace
4. Click on the picture placeholder to set the workspace picture
5. Select a picture for the workspace

Expected Result:

The "Edit photo" page opens with the zoom slider and save button not overlapping.

Actual Result:

Save button overlaps with zoom slider with the zoom slider in the edit photo page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6802463_1744702506585.video_2025-04-15_10-34-37.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912814879302183164
• Upwork Job ID: 1912814879302183164
• Last Price Increase: 2025-04-17
• Automatic offers:
• samranahm | Contributor | 106981097

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button overlaps the zoom slider when setting workspace picture

What is the root cause of that problem?

This happen because here

App/src/components/AvatarCropModal/AvatarCropModal.tsx

Lines 355 to 359 in 1f5363b

	<ScreenWrapper
	style={[styles.pb0]}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom={false}
	testID={AvatarCropModal.displayName}

we are currently not using shouldEnableKeyboardAvoidingView that lead to show save button on top because keyboard was not properly closed

What changes do you think we should make in order to solve the problem?

we should pass
shouldEnableKeyboardAvoidingView={false}

here

App/src/components/AvatarCropModal/AvatarCropModal.tsx

Lines 355 to 359 in 1f5363b

	<ScreenWrapper
	style={[styles.pb0]}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom={false}
	testID={AvatarCropModal.displayName}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On the photo editing page, the Save button overlaps with the zoom slider. This occurs after the user selects an image to edit.

What is the root cause of that problem?

• After a user picks an image, the keyboard briefly opens before the AvatarCropModal is displayed.
• The AvatarCropModal is wrapped inside a KeyboardAvoidingView, which automatically adjusts the screen height when the keyboard is visible.
• When the modal opens, the keyboard hasn’t fully closed yet. As a result, KeyboardAvoidingView incorrectly assumes the keyboard is still open and adds extra bottom padding to accommodate it.
• This padding causes layout shifts, leading to the Save button overlapping with the zoom slider.

What changes do you think we should make in order to solve the problem?

• We should explicitly dismiss (using Keyboard.dismiss() or our custom KeyboardUtils.dismiss()) the keyboard in this block:
  

  App/src/components/AvatarWithImagePicker.tsx

  Lines 322 to 327 in 1f5363b

  	if (isUsingDefaultAvatar) {
  	openPicker({
  	onPicked: (data) => showAvatarCropModal(data.at(0) ?? {}),
  	});
  	return;
  	}

This change would:

1. Resolve the overlapping Save button and zoom slider issue.
2. Prevent the flickering effect that occurs immediately after a user selects an option below:

• A feature flag should be introduced to gate this change, ensuring it is only applied when explicitly enabled. This will help prevent regressions or unintended side effects in other flows.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• This is a native issue related to keyboard visibility and layout behavior, so it’s difficult to cover with automated testing. Manual testing across platforms (iOS/Android) and device types should be emphasized.

What alternative solutions did you explore? (Optional)

• N/A

[kadiealexander]

Android <> iOS bug swap

[jliexpensify]

I'm almost certain that this is Android-device specific - I cannot reproduce this on my Pixel 7.

[jliexpensify]

@nlemma can you re-test this on 9.1.28.13? I think it got released today. Also @samranahm and @thelullabyy - if you have physical Android devices, can you re-test this on the newest Hybrid version?

[thelullabyy]

@jliexpensify I’m not sure how to test this bug in the hybrid Android, but I was able to reproduce it on the Android standalone build using the Android simulator:

Screen.Recording.2025-04-17.at.16.43.06.mov

Note: The bug isn’t consistently reproducible—you may need to repeat the test steps several times before it appears.

[jliexpensify]

Hmm I'm confused by your video @thelullabyy - this is the bug:

Your save button looks fine?

I still can't reproduce this one 🤷‍♂ I'll make it external and see if C+ can repro