Skip to content

[Better Expense Report View] Update the report preview action #60214

Description

@mountiny

Problem

We are inconsistent with what report total we use in the report action buttons in the workspace chat when the user can, for example, submit a report of a certain value.

Solution

Let's clean this up to achieve this set-up:

  • Submit: use overall report total
  • Review: use overall report total
  • Approve: use overall report total
  • Pay: only use the amount that would actually be paid
  • Export: we don't use the total here

Let's abstract this logic into a separate method and cover its logic with automated tests.

Note this means we would also include the held items values in the overall report total - as we already show the hold modal for the users to confirm before action is actually completed.

Issue OwnerCurrent Issue Owner: @JakubKorytko

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions