[Due for payment 2025-05-14] [$250] Expense Reports-After closing receipt view, app opens Inbox (web), iOS app reopens same report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #59735
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with receipt.
4. Go to Reports > Expense Reports.
5. Click on the expense report from Step 3.
6. Click on the receipt.
7. On web, click X button to close the receipt view.
8. On mweb, Android/iOS, tap app back button, then tap app back button again.

Expected Result:

On web (Step 7), app will remain on Reports page after closing receipt view.
On mweb, Android/iOS, after closing receipt view and tapping app back button, app will return to Expense Reports.

Actual Result:

On web (Step 7), app opens Inbox after closing receipt view.
On mweb, Android/iOS, after closing receipt view and tapping app back button, app reopens the same report.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6799227_1744358320737.iOS.mp4

Bug6799227_1744358320756.web_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021911809936832796582
• Upwork Job ID: 1911809936832796582
• Last Price Increase: 2025-04-14

Issue Owner

Current Issue Owner: @sakluger / @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On web (Step 7), app opens Inbox after closing receipt view.
On mweb, Android/iOS, after closing receipt view and tapping app back button, app reopens the same report.

What is the root cause of that problem?

We don't handle case that we open the receipt in Expense Report in Search page

App/src/pages/TransactionReceiptPage.tsx

Lines 97 to 103 in d0c12b6

	// Receipt Page can be opened either from Reports or from Search RHP view
	// We have to handle going back to correct screens, if it was opened from RHP just close the modal, otherwise go to Report Page
	const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
	const secondToLastRoute = rootState.routes.at(-2);
	if (secondToLastRoute?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR || isDraftTransaction) {
	Navigation.dismissModal();
	} else {

What changes do you think we should make in order to solve the problem?

WE should add the case we open the receipt in Expense Report in Search page by updating the condition here

       if (secondToLastRoute?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR || secondToLastRoute?.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR || isDraftTransaction) {
            Navigation.dismissModal();
        } 

App/src/pages/TransactionReceiptPage.tsx

Lines 101 to 103 in d0c12b6

	if (secondToLastRoute?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR || isDraftTransaction) {
	Navigation.dismissModal();
	} else {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Closing the receipt preview from search page leads the user to the report screen.

What is the root cause of that problem?

When the modal close, we use dismiss modal with a reportID that will open the report page.

App/src/pages/TransactionReceiptPage.tsx

Lines 96 to 112 in 6569205

	const onModalClose = () => {
	// Receipt Page can be opened either from Reports or from Search RHP view
	// We have to handle going back to correct screens, if it was opened from RHP just close the modal, otherwise go to Report Page
	const rootState = navigationRef.getRootState() as State<RootNavigatorParamList>;
	const secondToLastRoute = rootState.routes.at(-2);
	if (secondToLastRoute?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR || isDraftTransaction) {
	Navigation.dismissModal();
	} else {
	const isOneTransactionThread = isOneTransactionThreadReportUtils(report?.reportID, report?.parentReportID, parentReportAction);
	const dismissModalReportID = isOneTransactionThread ? report?.parentReportID : report?.reportID;
	if (!dismissModalReportID) {
	Navigation.dismissModal();
	return;
	}
	Navigation.dismissModalWithReport({reportID: dismissModalReportID});
	}
	};

When it was implemented, we use goBack with fallback route to the report details (it should be report). But now, we have a complex condition to decide whether to use dismiss modal with or without report.

What changes do you think we should make in order to solve the problem?

I suggest to simplify it by just using dismissModal for all cases.
onModalClose={Navigation.dismissModal}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021911809936832796582

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)