[$250] (Archived) title not showing up for admins and announce room in offline mode

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @srikarparsi
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a new workspace
2. Invite 3 members to create an admins room
3. Go offline
4. Delete the workspace

Expected Result:

The admins chat will have (archived) appended to the title

Actual Result:

The admins chat will not have (archived) appended to the title (even though it has the private_isArchived RNVP)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1132.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910383986494240814
• Upwork Job ID: 1910383986494240814
• Last Price Increase: 2025-04-10
• Automatic offers:
• nkdengineer | Contributor | 106918893

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The admins chat will not have (archived) appended to the title (even though it has the private_isArchived RNVP)

What is the root cause of that problem?

The cache key of the admin report is still the same after we delete the workspace Then this function still returns the report name without Archived.

App/src/libs/ReportUtils.ts

Lines 4572 to 4575 in e7a9622

	if (reportID) {
	const reportNameFromCache = reportNameCache.get(cacheKey);
	if (reportNameFromCache?.reportName && reportNameFromCache.reportName === report?.reportName && reportNameFromCache.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME) {

What changes do you think we should make in order to solve the problem?

We should also append reportNameValuePairs.private_isArchived to the cache key of the report.

App/src/libs/ReportUtils.ts

Line 4512 in e7a9622

const getCacheKey = (report: OnyxEntry<Report>): string => `${report?.reportID}-${report?.lastVisibleActionCreated}-${report?.reportName}`;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Render LHN with the admin report after that delete the workspace and verify that the title is updated with Archived

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910383986494240814

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

(Archived) title not showing up for admins and announce room in offline mode

What is the root cause of that problem?

This happen because #admins and announce room get its reportName from cache

App/src/libs/ReportUtils.ts

Line 4576 in b83750a

return reportNameFromCache.reportName;

and the cacheKey only update when report?.lastVisibleActionCreated changes

So, when we delete the policy report?.lastVisibleActionCreated remain same and for #admins and #announce room same message display because it could not reach this point

App/src/libs/ReportUtils.ts

Line 4753 in b83750a

if (isArchivedNonExpenseReport(report, getReportNameValuePairs(report?.reportID))) {

What changes do you think we should make in order to solve the problem?

We should explicitly check reportNameValuePairs and if we have private_isArchived mean that policy has been deleted or said report is isArchived and because we need to change the name of all reports that are Archived or was part of policy that deletes, we should not be getting the name from cache when policy deleted.

We should add !currentReportNameValuePairs?.private_isArchived in this check so as soon the report get private_isArchived this this logic will not trigger

App/src/libs/ReportUtils.ts

Lines 4573 to 4575 in b83750a

	const reportNameFromCache = reportNameCache.get(cacheKey);
	if (reportNameFromCache?.reportName && reportNameFromCache.reportName === report?.reportName && reportNameFromCache.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME) {

to

    const reportNameFromCache = reportNameCache.get(cacheKey);
    const currentReportNameValuePairs = getReportNameValuePairs(report?.reportID, reportNameValuePairs);

    if (reportNameFromCache?.reportName && reportNameFromCache.reportName === report?.reportName && reportNameFromCache.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME && !currentReportNameValuePairs?.private_isArchived) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

We can also use this function

App/src/libs/ReportUtils.ts

Line 1910 in b83750a

function isArchivedReportWithID(reportOrID?: string | SearchReport) {

to as

   if (reportNameFromCache?.reportName && reportNameFromCache.reportName === report?.reportName && reportNameFromCache.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME && !isArchivedReportWithID(reportID)) {

Alternative solution B
Here

App/src/libs/ReportUtils.ts

Line 4512 in b83750a

const getCacheKey = (report: OnyxEntry<Report>): string => `${report?.reportID}-${report?.lastVisibleActionCreated}-${report?.reportName}`;

We should check if isArchivedReport then append reportNameValuePair?.private_isArchived to cacheKey

const getCacheKey = (report: OnyxEntry<Report>): string => {
    if (isArchivedReportWithID(report?.reportID)) {
        const reportNameValuePair = getReportNameValuePairs(report?.reportID);
        return `${report?.reportID}-${report?.lastVisibleActionCreated}-${report?.reportName}-${reportNameValuePair?.private_isArchived}`;
    }

    return `${report?.reportID}-${report?.lastVisibleActionCreated}-${report?.reportName}`;
};

Adding private_isArchived directly in cacheKeycould cause the regression since its undefined when report is not archived

[github-actions]

⚠️ @Tony-MK Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).