[Due for payment 2025-05-05] [$250] Expense Reports - Modal does not appear after right-clicking on the reacted emoji

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Go to Reports.
5. Go to Expense Reports.
6. Click on the expense report from Step 3.
7. Send a message.
8. Right click on the message and add a reaction.
9. Right click on the reacted emoji.

Expected Result:

A modal will appear after right-clicking on the reacted emoji.

Actual Result:

A modal does not appear after right-clicking on the reacted emoji.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6797355_1744218161456.bandicam_2025-04-10_00-59-03-830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910709268863926488
• Upwork Job ID: 1910709268863926488
• Last Price Increase: 2025-04-11
• Automatic offers:
• nkdengineer | Contributor | 106920057

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 17:58:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Modal does not appear after right-clicking on the reacted emoji

What is the root cause of that problem?

We did not add PopoverReactionList and subscribe to ReactionListContext in MoneyRequestReportActionsList

What changes do you think we should make in order to solve the problem?

Add PopoverReactionList to MoneyRequestReportActionsList

const reactionListRef = useContext(ReactionListContext);
...
<PopoverReactionList ref={reactionListRef} />

App/src/pages/home/report/ReportActionsView.tsx

Line 78 in 3e6a680

const reactionListRef = useContext(ReactionListContext);

App/src/pages/home/report/ReportActionsView.tsx

Line 306 in 3e6a680

<PopoverReactionList ref={reactionListRef} />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A modal does not appear after right-clicking on the reacted emoji.

What is the root cause of that problem?

We didn't add <PopoverReactionList ref={reactionListRef} /> for money report page as what we did in ReportActionsView.tsx

What changes do you think we should make in order to solve the problem?

We should create the ReportActionListWrapper

const ReportActionListWrapper = ({children}: {children: React.ReactNode}) => {
    const reactionListRef = useRef<ReactionListRef>(null);
    return (
        <ReactionListContext.Provider value={reactionListRef}>
            {children}
            <PopoverReactionList ref={reactionListRef} />
        </ReactionListContext.Provider>

    )
}

and use it in ReportScreen and SearchMoneyRequestReportPage and remove the use of <PopoverReactionList ref={reactionListRef} /> in ReportActionsView.

By doing this way we can make sure this issue doesn't happen in the future and avoid duplicated code

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910709268863926488

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[dangrous]

can grab internal review here when ready