[Payment due 4/23][$250] Expense - App is not responsive after closing receipt view on confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Click + > Create expense > Manual
4. Enter amount > Next
5. On the confirmation page, add a receipt
6. Click on the receipt
7. Click 3-dot menu > Replace
8. Before receipt RHP opens, quickly click on the existing receipt on the confirmation page
9. Click X button to close the view
10. Click anywhere

Expected Result:

App will be responsive to clicks

Actual Result:

App is no longer responsive to clicks

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6797224_1744208931914.Screen_Recording_2025-04-09_at_22.20.01.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909989194567648165
• Upwork Job ID: 1909989194567648165
• Last Price Increase: 2025-04-09

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

I can reproduce this - let's start with external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909989194567648165

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The app becomes unresponsive to clicks after closing a receipt view, creating a poor user experience.

What is the root cause of that problem?

• In the following code section:
  

  App/src/components/AttachmentModal.tsx

  Lines 454 to 456 in 0209727

  	closeModal(true);
  	InteractionManager.runAfterInteractions(() => {
  	Navigation.navigate(

  There is a delay between the navigation action and the modal close action. This causes a brief period during which the user can interact with the confirmation screen.

• After completing step 8, a transaction receipt screen is pushed onto the navigation stack as follows:

├─ TransactionReceipt
└─ RightModalNavigator
   └─ STACK
      └─ MoneyRequest
         └─ STACK
            └─ Money_Request_Step_Scan 

• When the user clicks the "X" button to close the modal, only the Money_Request_Step_Scan screen is dismissed. The TransactionReceipt screen remains on the stack and becomes visible again, leading to an unresponsive state when interacting with the app post-dismissal.

What changes do you think we should make in order to solve the problem?

• We can minimize the delay and ensure smoother navigation by wrapping the navigate call in a setTimeout with zero delay:

setTimeout(() => {
    Navigation.navigate(
        ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
            iouAction ?? CONST.IOU.ACTION.EDIT,
            iouType,
            draftTransactionID ?? transaction?.transactionID,
            report?.reportID,
            Navigation.getActiveRouteWithoutParams(),
        ),
    );
}, 0);

This ensures the navigation happens immediately after the modal close without creating a visible gap or allowing intermediate interaction.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

• N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App is no longer responsive to clicks

What is the root cause of that problem?

When users press replace receipt, we're delaying navigate

App/src/components/AttachmentModal.tsx

Lines 454 to 456 in 0209727

	closeModal(true);
	InteractionManager.runAfterInteractions(() => {
	Navigation.navigate(

In this time, user can press the receipt to open the attachment modal, so the modal is shown

after interaction, the moneyRequestScan page is shown behind the modal, and somehow it create new transparent overlay. If users close the modal, just only the modal's overlay is removed, so users can't interact with the component behind the transparent overlay

What changes do you think we should make in order to solve the problem?

We should add InteractionManager.runAfterInteractions when users click on the receipt in

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 739 to 744 in 0209727

	Navigation.navigate(
	isReceiptEditable
	? ROUTES.TRANSACTION_RECEIPT.getRoute(reportID, transactionID, undefined, undefined, action, iouType)
	: ROUTES.TRANSACTION_RECEIPT.getRoute(reportID, transactionID),
	);
	}}

and

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 714 to 719 in 0209727

	Navigation.navigate(
	isReceiptEditable
	? ROUTES.TRANSACTION_RECEIPT.getRoute(reportID, transactionID, undefined, undefined, action, iouType)
	: ROUTES.TRANSACTION_RECEIPT.getRoute(reportID, transactionID),
	);
	}}

by default, there's no interaction so navigation is triggered immediately. In case the moneyRequestScan is about to open then users press receipt, this way makes sure receipt modal is open after moneyRequestScan

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

We can prevent users's interaction if moneyRequestScan is about to open

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.