[Due for payment 2025-05-06] [$250] Recipient picker during Create expense flow has wrong text on workspaces

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.24-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to create expense from global plus
2. Select Manual and enter any amount and click next
3. In Confirm details screen Click "To" to change the recipient

Expected Result:

The list of recipient displayed as
Workspace name
Submits to [approver ]

Actual Result:

Recipient shows a list of XXXXX' s expenses (Submitter's display name) followed by Workspace

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1124.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021911938871026548288
• Upwork Job ID: 1911938871026548288
• Last Price Increase: 2025-04-22
• Automatic offers:
• FitseTLT | Contributor | 107037819

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Recipient shows a list of XXXXX' s expenses (Submitter's display name) followed by Workspace

What is the root cause of that problem?

The participants are returned from getReportOption if the report isn't DM.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 168 in 9eb3655

return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant);

We return the option.text is the policy name if the report isn't the invoice room. So the title of the To field is different

App/src/libs/OptionsListUtils.ts

Lines 947 to 953 in 9eb3655

	if (option.isSelfDM) {
	option.alternateText = translateLocal('reportActionsView.yourSpace');
	} else if (option.isInvoiceRoom) {
	option.text = getReportName(report);
	option.alternateText = translateLocal('workspace.common.invoices');
	} else {
	option.text = getPolicyName({report});

What changes do you think we should make in order to solve the problem?

We should also return the reportName here

option.text = getReportName(report);

App/src/libs/OptionsListUtils.ts

Line 953 in 9eb3655

option.text = getPolicyName({report});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create the test with getReportOption function and assert the text field is correct with policy expense report.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Recipient picker during Create expense flow has wrong text on workspaces

What is the root cause of that problem?

The text and alternate text we add for the policy chats options here which comes from useOptionsList

App/src/libs/OptionsListUtils.ts

Lines 1518 to 1519 in 7f80b75

	if (shouldSeparateWorkspaceChat && newReportOption.isOwnPolicyExpenseChat && !newReportOption.private_isArchived) {
	workspaceChats.push(newReportOption);

differs from, as indicated in the OP, from the report option we calculate here for workspace participants in confirmation page

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 168 in 7f80b75

return participant.accountID ? getParticipantsOption(participant, personalDetails) : getReportOption(participant);

What changes do you think we should make in order to solve the problem?

We can use the text and alternateText calculation in getReportOption and set it

 if (shouldSeparateWorkspaceChat && newReportOption.isOwnPolicyExpenseChat && !newReportOption.private_isArchived) {
            const reportOption = getReportOption(option);
            workspaceChats.push({...newReportOption, text: reportOption.text, alternateText: reportOption.alternateText});
        }

We can also optionally rewrite the logic here instead of using getReportOption.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test getValidReports to assert with the new change it returns for workspace chats

What alternative solutions did you explore? (Optional)

If we want to make the changes globally in the App for own expense chats we can alter the logic in createOption accordingly

[melvin-bot]

@alexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021911938871026548288

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)