[Due for payment 2025-06-05] $250] Search - Inconsistent latest message of self DM after selecting an option of whisper

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #59282
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: SS S20 FE/ Android 13
App Component: Search

Action Performed:

Precondition: sent a message and an expense to self DM

1. Open app
2. Note that latest message in search result and latest message of self DM is consistent
3. Send an expense in self DM
4. Select whisper option "Nothing for now"
5. Navigate to search result
6. Note that the latest message is whisper action question, the latest message in self DM is about expense

Expected Result:

The latest message in search result and latest message of self DM is consistent

Actual Result:

The latest message is whisper action question, the latest message in self DM is about expense

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909674297584862254
• Upwork Job ID: 1909674297584862254
• Last Price Increase: 2025-04-15

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-16 15:14:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In search router, the last message still shows the actionable track options message even after resolving it.

What is the root cause of that problem?

When we resolve the actionable track options, the report action is updated. OptionsListUtils.getLastMessageTextForReport will then return the tracking xxx as the last message. However, on the search router, the recalculations aren't happening.

App/src/libs/OptionsListUtils.ts

Line 885 in 689e60c

const lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails);

It's because the list is only updated if either reports, reportNameValuePairs, or preferredLocale changes.

App/src/components/OptionListContextProvider.tsx

Lines 56 to 76 in 689e60c

	/**
	* This effect is used to update the options list when reports change.
	*/
	useEffect(() => {
	// there is no need to update the options if the options are not initialized
	if (!areOptionsInitialized.current || !reports) {
	return;
	}
	// Since reports updates can happen in bulk, and some reports depend on other reports, we need to recreate the whole list from scratch.
	const newReports = createOptionList(personalDetails, reports).reports;
	setOptions((prevOptions) => {
	const newOptions = {
	...prevOptions,
	reports: newReports,
	};
	return newOptions;
	});
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [reports, reportNameValuePairs, preferredLocale]);

What changes do you think we should make in order to solve the problem?

We can create a new useEffect that recalculate the options, but only the report that the report actions are changed.

const [_, {sourceValue: changedReportActions}] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS);

useEffect(() => {
    if (!changedReportActions || !areOptionsInitialized.current) {
        return;
    }

    setOptions((prevOptions) => {
        const changedReportActionsEntries = Object.entries(changedReportActions);
        if (changedReportActionsEntries.length === 0) {
            return prevOptions;
        }

        const updatedReportsMap = new Map(prevOptions.reports.map((report) => [report.reportID, report]));
        changedReportActionsEntries.forEach(([key, reportAction]) => {
            if (!reportAction) {
                return;
            }

            const reportID = key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, '');
            const {reportOption} = processReport(updatedReportsMap.get(reportID)?.item, personalDetails);

            if (reportOption) {
                updatedReportsMap.set(reportID, reportOption);
            }
        });

        return {
            ...prevOptions,
            reports: Array.from(updatedReportsMap.values()),
        };
    });
}, [changedReportActions, personalDetails]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909674297584862254

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[ntdiary]

@bernhardoj, LGTM, and just curious, this won't have much performance impact, right? :D

[bernhardoj]

It will indeed have a performance impact, but hopefully, it won't have much impact :) (since we already have reports and look like we don't have a problem with it, at least that I know of).

[ntdiary]

I asked about it on Slack, and haven’t gotten a reply yet. I might try it later with a heavy account to see how the solution performs. :D