[hold for payment 2025-04-23] [$250] iOS&Android - Workspace switcher - App returns to Inbox after unselecting current workspace on Reports

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.23-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Other

Action Performed:

Precondition:

• User has at least one workspace.

1. Launch Expensify app.
2. On Inbox, open workspace switcher.
3. Select a workspace.
4. Go to Reports.
5. Open workspace switcher.
6. Tap on the selected workspace.

Expected Result:

App will stay on Reports page after unselecting the current workspace.

Actual Result:

App returns to Inbox after unselecting the current workspace on Reports.
When swiping back, app reopens the same Inbox page but workspace filter is reapplied.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6791476_1743704991120.ScreenRecording_04-04-2025_02-14-28_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021908168256682974884
• Upwork Job ID: 1908168256682974884
• Last Price Increase: 2025-04-04
• Automatic offers:
• nkdengineer | Contributor | 106840541

Issue Owner

Current Issue Owner: @yuwenmemon

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after unselecting the current workspace on Reports.
When swiping back, app reopens the same Inbox page but workspace filter is reapplied.

What is the root cause of that problem?

If we unselect the policy, this logic is triggered that will replace the current search full screen navigator to report split navigator. The problem is that we always get the topmostReportSplit without checking if the current topmost central is the report split or not.

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 42 to 60 in c91bf20

	const topmostReportSplit = getTopmostReportsSplitNavigator();
	const topmostReportSplitPolicyID = topmostReportSplit?.params && `policyID` in topmostReportSplit.params ? topmostReportSplit.params.policyID : undefined;
	const hasWorkspaceBeenDeleted = !activeWorkspace && activeWorkspaceResult.status === 'loaded' && !!topmostReportSplitPolicyID;
	if (!topmostReportSplit || !hasWorkspaceBeenDeleted || isLoading) {
	return;
	}
	// Switching workspace to global should only be performed from the currently opened sidebar screen
	const topmostReportSplitState = topmostReportSplit?.state ?? getPreservedNavigatorState(topmostReportSplit?.key);
	const isCurrentSidebar = topmostReportSplitState?.routes.some((route) => currentRoute.key === route.key);
	if (!isCurrentSidebar) {
	return;
	}
	const reportsSplitNavigatorWithoutPolicyID = getInitialSplitNavigatorState({name: SCREENS.HOME}, {name: SCREENS.REPORT});
	Navigation.replaceWithSplitNavigator(reportsSplitNavigatorWithoutPolicyID);
	updateLastAccessedWorkspace(undefined);

What changes do you think we should make in order to solve the problem?

We should return early if the topmost navigator is not report split navigator

if (!isReportTopmostSplitNavigator()) {
    return;
}

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 42 to 60 in c91bf20

	const topmostReportSplit = getTopmostReportsSplitNavigator();
	const topmostReportSplitPolicyID = topmostReportSplit?.params && `policyID` in topmostReportSplit.params ? topmostReportSplit.params.policyID : undefined;
	const hasWorkspaceBeenDeleted = !activeWorkspace && activeWorkspaceResult.status === 'loaded' && !!topmostReportSplitPolicyID;
	if (!topmostReportSplit || !hasWorkspaceBeenDeleted || isLoading) {
	return;
	}
	// Switching workspace to global should only be performed from the currently opened sidebar screen
	const topmostReportSplitState = topmostReportSplit?.state ?? getPreservedNavigatorState(topmostReportSplit?.key);
	const isCurrentSidebar = topmostReportSplitState?.routes.some((route) => currentRoute.key === route.key);
	if (!isCurrentSidebar) {
	return;
	}
	const reportsSplitNavigatorWithoutPolicyID = getInitialSplitNavigatorState({name: SCREENS.HOME}, {name: SCREENS.REPORT});
	Navigation.replaceWithSplitNavigator(reportsSplitNavigatorWithoutPolicyID);
	updateLastAccessedWorkspace(undefined);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[joekaufmanexpensify]

Reproduced.

[joekaufmanexpensify]

This works correctly if you originally selected the workspace from the reports page. It's only an issue if you select it from inbox and then navigate to reports.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021908168256682974884