[Due for payment 2025-04-10] [$125] [Better Expense Report View] Wrong icon is displayed for approved and paid report preview

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #58479
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Click Submit.
5. Click Approve.
6. Click Pay elsewhere.

Expected Result:

In Step 5, expense preview will show thumbs up icon for approved report.
In Step 6, expense preview will show checkmark for paid report.

Actual Result:

In Step 5, expense preview shows checkmark icon for approved report.
In Step 6, expense preview shows thumbs up for paid report.
Issue happens with Expensifail accounts.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6789006_1743521660865.20250401_232044.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907185915072760578
• Upwork Job ID: 1907185915072760578
• Last Price Increase: 2025-04-01
• Automatic offers:
• allgandalf | Reviewer | 106790660
• DylanDylann | Contributor | 106790662

Issue Owner

Current Issue Owner: @johncschuster

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, expense preview shows checkmark icon for approved report.
In Step 6, expense preview shows thumbs up for paid report.
Issue happens with Expensifail accounts.

What is the root cause of that problem?

we are checking in the wrong order here

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 429 to 438 in 560c3dd

	const approvedOrSettledicon = (iouSettled || isApproved) && (
	<ImageSVG
	src={isApproved ? Expensicons.Checkmark : Expensicons.ThumbsUp}
	fill={isApproved ? theme.iconSuccessFill : theme.icon}
	width={20}
	height={20}
	style={{transform: 'translateY(4px)'}}
	contentFit="cover"
	/>
	);

What changes do you think we should make in order to solve the problem?

Update the above condition to show the correct icon.

            src={isApproved ? Expensicons.ThumbsUp : Expensicons.Checkmark}
            fill={isApproved ? theme.icon : theme.iconSuccessFill}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

@roryabraham i can help to raise quick PR if needed