[PAID] [$500] Unable to find the #admin chat by searching

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dbarret
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

1. Search for #admin chat for a workspace where user is owner

Expected Result:

Able to find the # admin chat by searching

Actual Result:

Unable to find even by scrolling

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Please refer to the OP slack for screenshots and videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021906462140017305540
• Upwork Job ID: 1906462140017305540
• Last Price Increase: 2025-04-17
• Automatic offers:
• allgandalf | Contributor | 106729203

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[andriivitiv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to find the #admins room by searching

What is the root cause of that problem?

The #admins room is hidden unless there is more than 1 workspace admin or the room has messages/audit logs.

App/src/libs/ReportUtils.ts

Lines 7475 to 7478 in 3ffa779

	// Show #admins room only when it has some value to the user.
	if (isAdminRoom(report) && !shouldAdminsRoomBeVisible(report)) {
	return null;
	}

This behavior is expected in the LHN, however, since this function (reasonForReportToBeInOptionList) is also used to filter search results, the room is hidden there as well.

What changes do you think we should make in order to solve the problem?

To always display the #admins room in search, we can add an additional parameter includeAdminsRoom = false, to the reasonForReportToBeInOptionList function. Then modify the condition as follows:

-if (isAdminRoom(report) && !shouldAdminsRoomBeVisible(report)) {
+if (isAdminRoom(report) && !shouldAdminsRoomBeVisible(report) && !includeAdminsRoom) {

Next, add the same parameter to the getValidReports function and pass it to shouldReportBeInOptionList.

Finally, pass includeAdminsRoom: true, here.

This change will ensure that the #admins room always appears in search results while preserving the current behavior in the LHN.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a unit test in OptionsListUtilsTest.ts for the getSearchOptions function to verify that the #admins room is always shown in search results.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021906462140017305540