[Due for payment 2025-04-23] [Due for payment 2025-04-14] [$125] Empty state animation does not show when switching the tabs

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kubabutkiewicz
Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

1. Go to the Reports tab.
2. Search for something that does not exist and observe the empty state animation.
3. Navigate to a different tab, e.g., Settings.
4. Go back to Search using the Back button.

Expected Result:

The empty state animation should be displayed.

Actual Result:

The empty state animation does not appear.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1085.mp4

Screen.Recording.2025-03-25.at.13.25.13.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904673874830293667
• Upwork Job ID: 1904673874830293667
• Last Price Increase: 2025-03-25
• Automatic offers:
• nkdengineer | Contributor | 106709197

Issue Owner

Current Issue Owner: @sakluger

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The empty state animation does not appear.

What is the root cause of that problem?

We are not rendering EmptySearchView again when user clicks to the device back button

App/src/components/Search/index.tsx

Lines 370 to 379 in 57c8241

	if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type)) {
	return (
	<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
	<EmptySearchView
	type={type}
	hasResults={searchResults.search.hasResults}
	/>
	</View>
	);
	}

What changes do you think we should make in order to solve the problem?

We should only show the EmptySearchView when isFocused is true and and it will re-render when the user returns to the search page.

    if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type) && isFocused) 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Or we can only render again EmptyStateComponent here when isFocus changed

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[sakluger]

This feels like a pretty simple change, so I'm going to set the price to $125. Let me know if you disagree.

@nkdengineer I'm not sure what's wrong with your proposal that triggered that automated comment, it looks like the proper format to me 🤷‍♂

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904673874830293667

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)