[Due for payment 2025-04-17] [$250] Android - Devices back button has to be tapped twice to return to the chat

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58676
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A52s 5G / Android 14
App Component: Other

Action Performed:

Precondition: A WS join link from a different account is copied to the clipboard.

1. Open the app
2. Log in with a new Gmail account
3. Choose the "Track" onboarding option
4. Track a manual expense in the self DM chat
5. Send the WS join link to the chat
6. Tap on the link
7. Tap on the Android "<" button on the bottom of the page
8. Tap on the Android "<" button on the bottom of the page again
9. Tap on the Android "<" button on the bottom of the page again

Expected Result:

I should be returned to the self DM.

Actual Result:

Devices back button has to be tapped twice to return to the chat at the settings page after tapping on a WS join link.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6779004_1742643455785.az_recorder_20250322_122032.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905590808062421178
• Upwork Job ID: 1905590808062421178
• Last Price Increase: 2025-03-28
• Automatic offers:
• allgandalf | Reviewer | 106749641

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Need to press back twice to arrives back at chat after opening a ws join link.

What is the root cause of that problem?

After we open the WS join link, we will call navigateAfterJoinRequest which navigates to SETTINGS (the bottom tab) and SETTINGS_WORKSPACES (the WS list).

App/src/libs/navigateAfterJoinRequest/index.ts

Lines 4 to 9 in 4750e38

	const navigateAfterJoinRequest = () => {
	Navigation.goBack(undefined, {shouldPopToTop: true});
	Navigation.navigate(ROUTES.SETTINGS);
	Navigation.navigate(ROUTES.SETTINGS_WORKSPACES.route);
	};
	export default navigateAfterJoinRequest;

However, both routes will push a SETTINGS_SPLIT_NAVIGATOR to the stack, so we have 2 settings navigator.

That's why we need to press back twice.

What changes do you think we should make in order to solve the problem?

We don't need to navigate to ROUTES.SETTINGS anymore, so we need to remove it.

We can apply it to the .web and .desktop platform files too.

(btw, looks like they all have the same implementation, so we can just merge it into 1 file)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905590808062421178

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)